HtmlEditor: make localization working for borderStyle selectbox if messages are loaded at runtime (T1234032) #28854
+47
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…25_!-localization-error-in-html-editor-selectbox-toolbar
ksercs
changed the title
ksercs
reviewed
Jan 29, 2025
| }; | ||
| } | ||
| }, () => { | ||
| test('SelectBox should show correct localization (T1234032)', function(assert) { |
There was a problem hiding this comment.
[to common test name]
Suggested change
| test('SelectBox should show correct localization (T1234032)', function(assert) { | |
| test('borderStyle selectbox items are localized even if messages are loaded at runtime (T1234032)', function(assert) { |
ksercs
reviewed
Jan 29, 2025
| test('SelectBox should show correct localization (T1234032)', function(assert) { | ||
| try { | ||
| localization.loadMessages(this.messages); | ||
| localization.locale('de'); |
There was a problem hiding this comment.
[refactoring]
let's get rid of try/finally and just do this localization stuff in beforeEach/afterEach
ksercs
reviewed
Jan 29, 2025
|
|
||
| assert.strictEqual($firstListItem.text(), 'Test', 'borderStyleEditor is correctly localized'); | ||
| } finally { | ||
| localization.locale(); |
There was a problem hiding this comment.
[mistake]
U call getter here, it does not change locale. You should pass a parameter to change locale
ksercs
reviewed
Jan 29, 2025
| showCellPropertiesForm(this.instance, $tableElement); | ||
| this.clock.tick(10); | ||
|
|
||
| const $borderStyleSelectBox = $(`.${SELECT_BOX_CONTAINER_CLASS} > input`); |
There was a problem hiding this comment.
[refactoring]
Kindly check how other tests in this file are written. I think you can avoid searching though DOM and just get necessary editor though API and check its items property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.