Chat.Editing: contextmenu integration #29672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contextMenu: support behavior when scrolling + positioning
EugeniyKiyashko
force-pushed
the
25_1_chat_editing_context_menu
branch
from
531d607 to
e29ccfc
Compare
vladaskorohodova
previously approved these changes
Apr 23, 2025
packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageList.tests.js
Outdated
Show resolved
Hide resolved
anna-shakhova
approved these changes
Apr 23, 2025
vladaskorohodova
approved these changes
Apr 23, 2025
ksercs
reviewed
Apr 23, 2025
Contributor
There was a problem hiding this comment.
Looks like there is an issue with verical centering in generic
| onMessageDeleting, | ||
| } = this.option(); | ||
|
|
||
| const editText = messageLocalization.format('dxChat-editingEditMessage'); |
Contributor
There was a problem hiding this comment.
it's bette to place it near the place of usage inside of if. Now we get this data even when it's no needed
| hideOnParentScroll: false, | ||
| overlayContainer: this._scrollView.content(), | ||
| visualContainer: this._scrollView.container(), | ||
| boundaryOffset: { h: 16 }, |
Contributor
There was a problem hiding this comment.
Let's create a constant SCROLLBAR_WIDTH to explain this magic number
| onCloseRootSubmenu: null, | ||
| onExpandLastSubmenu: null, | ||
| hideOnParentScroll: true, | ||
| visualContainer: window, |
Contributor
There was a problem hiding this comment.
Please add a _ prefix to point out that it's private properties
And also declare overlayContainer and boundaryOffset here as well just for consistency
| }); | ||
|
|
||
| QUnit.module('onMessageDeleting', moduleConfig, () => { | ||
| QUnit.test('should be called when the Edit button is clicked', function(assert) { |
| cssClass: CHAT_MESSAGELIST_CONTEXT_MENU_CONTENT_CLASS, | ||
| visible: false, | ||
| overlayContainer: this.getScrollView().content(), | ||
| visualContainer: this.getScrollView().container(), |
| }); | ||
|
|
||
| QUnit.module('OnMessageEditingStart', moduleConfig, () => { | ||
| QUnit.test('should be called when the Edit button is clicked', function(assert) { |
Contributor
There was a problem hiding this comment.
Isn't it a copypaste from messageList tests?
marker-dao
pushed a commit
to marker-dao/DevExtreme
that referenced
this pull request
Apr 29, 2025
Co-authored-by: ksercs <ksercs0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.