-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add angular 13 support #80
Feat: add angular 13 support #80
Conversation
BREAKING CHANGE: Angular 12 and earlier versions are not supported
Hello, Thank you for your contribution to TestCafe. We will review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hunhavoc,
You have done great work. Please make some corrections where I left comments. Add the necessary packages to the main package.json
from the demo package.json
to avoid errors with eslint
without running e2e
.
It's necessary to have the demo-app's eslint plugins installed before lint can be run.
@Aleksey28 thank you for reviewing my changes. Seems like I need to change the CI steps in order to run the new ESLint setup on the project. It took me some time to figure out why the lint script just works well on my computer and fails on CI. Reason is that the I hope this will solve the issue and the PR can be merged :) Also, meantime the @angular-eslint v13 was released, so I updated its version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, thank you for your efforts.
@Aleksey28 Sorry, I just missed one bit of your review comment, therefore I went a completely different way to solve the dependency issue. Anyways, both directions solve the issue, and thank you for accepting my way and my PR! |
Why is this closed? We need this. Please reopen it. |
@Aleksey28 If it looks good, be so kind to merge it and create a release. It would be so nice to being able to use Testcafe with Angular 13. |
This PR fixes #79
Besides fixing the root cause of the issue above, I updated the demo-app to Angular 13