Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add angular 13 support #80

Merged

Conversation

hunhavoc
Copy link
Contributor

This PR fixes #79

Besides fixing the root cause of the issue above, I updated the demo-app to Angular 13

@Farfurix
Copy link

Farfurix commented Nov 18, 2021

@hunhavoc

Hello,

Thank you for your contribution to TestCafe. We will review this PR.

Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hunhavoc,

You have done great work. Please make some corrections where I left comments. Add the necessary packages to the main package.json from the demo package.json to avoid errors with eslint without running e2e.

demo-app/.eslintrc.json Outdated Show resolved Hide resolved
src/testcafe/testcafe.builder.ts Outdated Show resolved Hide resolved
@hunhavoc hunhavoc requested a review from Aleksey28 December 3, 2021 11:07
@hunhavoc
Copy link
Contributor Author

hunhavoc commented Dec 3, 2021

@Aleksey28 thank you for reviewing my changes. Seems like I need to change the CI steps in order to run the new ESLint setup on the project. It took me some time to figure out why the lint script just works well on my computer and fails on CI. Reason is that the demo-app dependencies were install already on my copy, and it was not on the CI environment. Therefore I changed the CI steps by adding an additional step prior the lint step to install the demo-app dependencies too.

I hope this will solve the issue and the PR can be merged :)

Also, meantime the @angular-eslint v13 was released, so I updated its version.

Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, thank you for your efforts.

@hunhavoc
Copy link
Contributor Author

hunhavoc commented Dec 3, 2021

@Aleksey28 Sorry, I just missed one bit of your review comment, therefore I went a completely different way to solve the dependency issue.

Anyways, both directions solve the issue, and thank you for accepting my way and my PR!

@csutorasr
Copy link

Why is this closed? We need this. Please reopen it.

@csutorasr
Copy link

@Aleksey28 If it looks good, be so kind to merge it and create a release. It would be so nice to being able to use Testcafe with Angular 13.

@AndreyBelym AndreyBelym merged commit 701fa18 into DevExpress:master Dec 13, 2021
@hunhavoc hunhavoc deleted the fix/add-angular-13-support branch January 20, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema ID format is unsupported in Angular 13
5 participants