Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCafe can't detect test files located on a Windows network drive #3918

Closed
AndreyBelym opened this issue Jun 21, 2019 · 2 comments · Fixed by #3927
Closed

TestCafe can't detect test files located on a Windows network drive #3918

AndreyBelym opened this issue Jun 21, 2019 · 2 comments · Fixed by #3927
Labels
AREA: server STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: runner TYPE: bug The described behavior is considered as wrong (bug).
Milestone
Sprint #35

Comments

@AndreyBelym
Copy link
Contributor

What is your Test Scenario?

Use test files located on a network drive.

What is the Current behavior?

TestCafe says that there is no files.

What is the Expected behavior?

TestCafe should run tests from a network drive.

Explanation:

We use an old globby version for searching test files. It is built upon [isaacs/glob](http://github.com/isaacs/node-glob] that doesn't with network drives. Newer globby versions use fast-glob internally, that works well with network drives, but have different search algorithm: glob uses a depth-first search algorithm, fast-glob uses a width-first search algorithm. If we just update to the latest globby version, we can change test execution order.

Your Environment details:

  • testcafe version: 1.2.1
  • node.js version: 10.15.0
  • command-line arguments: testcafe chrome Z:\tests
  • browser name and version: any
  • platform and version: Windows
  • other:
@AndreyBelym AndreyBelym added TYPE: bug The described behavior is considered as wrong (bug). SYSTEM: runner AREA: server labels Jun 21, 2019
@AndreyBelym AndreyBelym added this to the Sprint #35 milestone Jun 21, 2019
@AndreyBelym
Copy link
Contributor Author

Related to:

isaacs/node-glob#290
isaacs/node-glob#74

@AndreyBelym AndreyBelym mentioned this issue Jun 24, 2019
Merged
miherlosev pushed a commit that referenced this issue Jun 26, 2019
@AndreyBelym @miherlosev
Fix test file scanning for Windows (closes #3918) (#3927)
c724cf8 
* Fix test file scanning for Windows

* Refactor after review

* Fix
@lock
Copy link

lock bot commented Jul 6, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Jul 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
@AndreyBelym @kirovboris
Fix test file scanning for Windows (closes DevExpress#3918) (DevExpre…
9a9bedc 
…ss#3927)

* Fix test file scanning for Windows

* Refactor after review

* Fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
AREA: server STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: runner TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Milestone
Sprint #35
Development

Successfully merging a pull request may close this issue.

Fix test file scanning for Windows (closes #3918) AndreyBelym/testcafe
1 participant
@AndreyBelym