Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestLogger works weird with concurrency >= 2 and CDP #7977

Closed
vasilyevi opened this issue Aug 28, 2023 · 8 comments
Closed

RequestLogger works weird with concurrency >= 2 and CDP #7977

vasilyevi opened this issue Aug 28, 2023 · 8 comments
Assignees
Labels
TYPE: bug The described behavior is considered as wrong (bug).

Comments

@vasilyevi
Copy link

What is your Scenario?

Trying to log the requests using RequestLogger and from time to time it shows incorrect data. I'm not able to reproduce the issue with concurrency = 1.

What is the Current behavior?

It does not log the correct requests.

I get the following error
1) TypeError: Cannot read properties of undefined (reading 'response')

I do log ne

What is the Expected behavior?

It have to

What is your public website URL? (or attach your complete example)

Sent the details to the support@devexpress.com

What is your TestCafe test code?

Sent the details to the support@devexpress.com

Your complete configuration file

const requestLogger = require("./tests/requestLogger");

module.exports = {
    screenshots: {
        path: "./artifacts/screenshots",
        takeOnFails: true,
        pathPattern: "${DATE}_${TIME}/${TEST}/${FILE_INDEX}_${QUARANTINE_ATTEMPT}.png",
        thumbnails: false
    },
    disableMultipleWindows: true,
    browsers: "chrome:headless",
    concurrency: 1,
    skipJsErrors: true,
    pageLoadTimeout: 40000,
    pageRequestTimeout: 45000,
    selectorTimeout: 15000,
    quarantineMode: false,
    hooks: {
        request: requestLogger,
    },
    disableNativeAutomation: false,

}

Your complete test report

No response

Screenshots

No response

Steps to Reproduce

Run the tests which I send to support@devexpress.com

TestCafe version

3.3.0-rc.1

Node.js version

v18.17.0

Command-line arguments

npx testcafe

Browser name(s) and version(s)

No response

Platform(s) and version(s)

No response

Other

No response

@vasilyevi vasilyevi added the TYPE: bug The described behavior is considered as wrong (bug). label Aug 28, 2023
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Aug 28, 2023
@AlexKamaev AlexKamaev added the STATE: Issue accepted An issue has been reproduced. label Aug 29, 2023
@github-actions
Copy link

We appreciate you taking the time to share the information about this issue. We replicated it, and it is currently in our internal queue. Please note that the research may take time. We'll update this thread once we have news.

@github-actions github-actions bot removed STATE: Need response An issue that requires a response or attention from the team. STATE: Issue accepted An issue has been reproduced. labels Aug 29, 2023
@AlexKamaev AlexKamaev self-assigned this Aug 30, 2023
AlexKamaev added a commit to AlexKamaev/testcafe that referenced this issue Aug 31, 2023
AlexKamaev added a commit to AlexKamaev/testcafe that referenced this issue Sep 4, 2023
AlexKamaev added a commit to AlexKamaev/testcafe that referenced this issue Sep 4, 2023
@vasilyevi
Copy link
Author

When do you plan to release the fix?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Sep 13, 2023
@PavelMor25
Copy link
Collaborator

At present, we can't give you an exact date as to when the next version will be released.

@AlexKamaev AlexKamaev removed the STATE: Need response An issue that requires a response or attention from the team. label Sep 14, 2023
@vasilyevi
Copy link
Author

but, it's a critical issue.... at least by my opinion...

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Sep 14, 2023
@AlexKamaev
Copy link
Contributor

We consider this issue important. That's why we tried to fix it as soon as possible. However, we cannot consider it critical because it does not affect a really big number of users. It is not a security issue, and it is not a crash. We still do not have the date of the next release. However, we usually try to release a new version every three/four weeks, so I hope it will be soon enough.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Sep 15, 2023
@vasilyevi
Copy link
Author

@AlexKamaev any news?

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 18, 2023
@AlexKamaev
Copy link
Contributor

@vasilyevi
We are still working on the new version. I hope it will be ready soon. However, I cannot give you the exact time frames.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 19, 2023
@github-actions
Copy link

Release v3.4.0-rc.1 addresses this.

@DevExpress DevExpress deleted a comment from github-actions bot Nov 2, 2023
@DevExpress DevExpress deleted a comment from github-actions bot Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

No branches or pull requests

3 participants