Incorrect screen size when resizeWindow() is called after maximizeWindow()

[htho]

What is your Scenario?

When testing my browser provider plugin I found that screen sizes are off, when resizeWindow() is called after maximizeWindow().

What is the Current behavior?

When I call resizeWindow() after maximizeWindow(),
then in Chrome (windowed mode, Windows 10) height is off by -1px,
and in Firefox (windowed mode, Windows 10) height is off by +10px and width is off by +4px.

What is the Expected behavior?

The screen size should be the size that was set by in resizeWindow().

What is the public URL of the test page? (attach your complete example)

I created a repository: https://github.com/htho/testcafe-repro-resize-after-maximize

What is your TestCafe test code?

import { fixture, test, ClientFunction } from "testcafe";

const targetWidth = 640;
const targetHeight = 480;
const targetDimensions = {width: targetWidth, height: targetHeight};

const getWindowInnerDimensions = ClientFunction(() => ({width: window.innerWidth, height: window.innerHeight}));

fixture("screenshot")
    .page("about:blank").
    // set size to something else so resize is necessary
    afterEach(async t => t.resizeWindow(targetWidth+13, targetHeight+13));

test("resizeWindow()", async t => {
    await t.resizeWindow(targetWidth, targetHeight);

    await t.expect(getWindowInnerDimensions()).eql(targetDimensions, "Window not resized properly!");
});

test("maximizeWindow() then resizeWindow() - fails", async t => {
    await t.maximizeWindow();
    
    await t.resizeWindow(targetWidth, targetHeight);
    
    await t.expect(getWindowInnerDimensions()).eql(targetDimensions, "Window not resized properly!");
});

test("maximizeWindow() then resizeWindow() twice", async t => {
    await t.maximizeWindow();
    
    await t.resizeWindow(targetWidth, targetHeight);
    await t.resizeWindow(targetWidth, targetHeight);
    
    await t.expect(getWindowInnerDimensions()).eql(targetDimensions, "Window not resized properly!");
});

Your complete configuration file

No response

Your complete test report

> .\node_modules\.bin\testcafe chrome .\test.tc.ts
 Running tests in:
 - Chrome 122.0.0.0 / Windows 10

 screenshot
 √ resizeWindow()
 × maximizeWindow() then resizeWindow() - fails

   1) AssertionError: Window not resized properly!: expected { width: 640, height: 479 } to deeply equal { width: 640, height: 480 }

      + expected - actual

       {
      -  height: 479
      +  height: 480
         width: 640
       }


      Browser: Chrome 122.0.0.0 / Windows 10

         20 |test("maximizeWindow() then resizeWindow() - fails", async t => {
         21 |    await t.maximizeWindow();
         22 |
         23 |    await t.resizeWindow(targetWidth, targetHeight);
         24 |
       > 25 |    await t.expect(getWindowInnerDimensions()).eql(targetDimensions, "Window not resized properly!");
         26 |});
         27 |
         28 |test("maximizeWindow() then resizeWindow() twice", async t => {
         29 |    await t.maximizeWindow();
         30 |

         at <anonymous> (C:\Dev\github.com\htho\testcafe-repro-resize-after-maximize\test.tc.ts:25:48)
         at fulfilled (C:\Dev\github.com\htho\testcafe-repro-resize-after-maximize\test.tc.ts:5:58)


 √ maximizeWindow() then resizeWindow() twice


 1/3 failed (14s)

> .\node_modules\.bin\testcafe firefox .\test.tc.ts
 Running tests in:
 - Firefox 123.0 / Windows 10

 screenshot
 √ resizeWindow()
 × maximizeWindow() then resizeWindow() - fails

   1) AssertionError: Window not resized properly!: expected { width: 644, height: 490 } to deeply equal { width: 640, height: 480 }

      + expected - actual

       {
      -  height: 490
      -  width: 644
      +  height: 480
      +  width: 640
       }


      Browser: Firefox 123.0 / Windows 10

         20 |test("maximizeWindow() then resizeWindow() - fails", async t => {
         21 |    await t.maximizeWindow();
         22 |
         23 |    await t.resizeWindow(targetWidth, targetHeight);
         24 |
       > 25 |    await t.expect(getWindowInnerDimensions()).eql(targetDimensions, "Window not resized properly!");
         26 |});
         27 |
         28 |test("maximizeWindow() then resizeWindow() twice", async t => {
         29 |    await t.maximizeWindow();
         30 |

         at <anonymous> (C:\Dev\github.com\htho\testcafe-repro-resize-after-maximize\test.tc.ts:25:48)
         at fulfilled (C:\Dev\github.com\htho\testcafe-repro-resize-after-maximize\test.tc.ts:5:58)


 √ maximizeWindow() then resizeWindow() twice

Screenshots

No response

Steps to Reproduce

1. > git clone https://github.com/htho/testcafe-repro-resize-after-maximize.git
2. > cd testcafe-repro-resize-after-maximize
3. > npm i
4. > npm run test

TestCafe version

3.5.0

Node.js version

21.6.2

Command-line arguments

testcafe chrome,firefox test.tc.ts

Browser name(s) and version(s)

Firefox 123, Chrome 122

Platform(s) and version(s)

Windows 10

Other

No response

[github-actions]

We appreciate you taking the time to share information about this issue. We reproduced the bug and added this ticket to our internal task queue. We'll update this thread once we have news.

[github-actions]

Release v3.6.1-rc.1 addresses this.