fix: The 'WebSocket connection closed' error on Chrome 130 #8297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testcafe-need-response-bot
bot
added
the
STATE: Need response
PavelMor25
removed
the
STATE: Need response
AlexKamaev
reviewed
Oct 14, 2024
src/browser/provider/built-in/dedicated/chrome/cdp-client/utils.ts
Outdated
Show resolved
Hide resolved
AlexKamaev
reviewed
Oct 14, 2024
src/browser/provider/built-in/dedicated/chrome/cdp-client/utils.ts
Outdated
Show resolved
Hide resolved
AlexKamaev
approved these changes
Oct 15, 2024
Bayheck
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When requesting active tabs in Chrome 130.0.6723.6, a chrome-extension tab is included in the list. A CDP client is created based on this tab, but the tab gets closed, which results in the error.
Approach
Excluded tabs with
^chrome-extensionURLs from the list of tabs.References
closes #8286
Pre-Merge TODO