Merged
Conversation
- Updated ScheduleBloc to handle preparation steps more effectively by introducing PreparationWithTime and modifying event emissions. - Refactored ScheduleState to include preparation details and adjusted state management for ongoing and upcoming schedules. - Removed unused helper methods and streamlined the preparation timing logic for better clarity and performance.
- Removed unnecessary BlocBuilder for AlarmTimerBloc in AlarmScreen, simplifying the state management. - Integrated ScheduleBloc to manage schedule and preparation step states more effectively. - Updated navigation logic to utilize ScheduleBloc for passing schedule data, improving code clarity and reducing dependencies. - Refactored AlarmScreen and AlarmScreenBottomSection to enhance readability and maintainability.
- Deleted AlarmScreenPreparationInfoBloc, its associated events and states to streamline the alarm management code. - Removed AlarmTimerBloc and its related events and states, simplifying the overall alarm functionality. - Enhanced code maintainability by eliminating redundant components that are no longer in use.
…gement - Added ScheduleBloc to HomeScreenTmp to manage today's schedule state more effectively. - Removed the state parameter from _TodaysScheduleOverlay and replaced it with a BlocBuilder to access schedule data. - Streamlined the rendering of today's schedule by directly utilizing the ScheduleBloc's state, improving code clarity and maintainability.
…_tmp - Deleted the _Character and _Slogan stateless widgets from home_screen_tmp.dart to streamline the code. - Improved maintainability by eliminating components that are no longer utilized in the current implementation.
- Deleted the unused theme import from home_screen_tmp.dart to clean up the code. - Improved maintainability by eliminating unnecessary dependencies that are not utilized in the current implementation.
|
Visit the preview URL for this PR (updated for commit 1689736): https://ontime-c63f1--pr320-306-schedule-prepari-zfskf8du.web.app (expires Mon, 22 Sep 2025 12:50:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7d60a2eae4c4a5839220ed6a57552a3b61cce5a3 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…gration - Removed the BlocProvider and BlocBuilder for AlarmTimerBloc from the preparation step list widget. - Streamlined the widget structure by directly using the PreparationStepListWidget, enhancing code clarity and maintainability.
- Added custom LLDB initialization file path to Runner.xcscheme for enhanced debugging support. - Enabled GPU validation mode in the scheme to assist with graphics-related debugging.
|
Visit the preview URL for this PR (updated for commit 1689736): https://on-time-front-widgetbook--pr320-306-schedule-prepari-pnkwi97t.web.app (expires Mon, 22 Sep 2025 12:50:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
yayo0
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes