Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draw polaroid frame w/ JS #6

Merged
merged 5 commits into from
Oct 18, 2016
Merged

draw polaroid frame w/ JS #6

merged 5 commits into from
Oct 18, 2016

Conversation

durka
Copy link
Contributor

@durka durka commented Oct 16, 2016

Fixes #4.

@durka
Copy link
Contributor Author

durka commented Oct 16, 2016

Screenshot:

@durka durka changed the title draw polaroid frame w/ CSS draw polaroid frame w/ JS Oct 16, 2016
@durka
Copy link
Contributor Author

durka commented Oct 16, 2016

Rebased on the new design.

New screenshot:

This was referenced Oct 17, 2016
@durka
Copy link
Contributor Author

durka commented Oct 17, 2016

Mobile screenshot:

It still doesn't work so great in landscape mode. The popup is too tall and scrolling doesn't work (it scrolls the page behind the popup). But we can fix that later, probably by reformatting (or eliminating!) the popup.

Copy link
Contributor

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@durka
Copy link
Contributor Author

durka commented Oct 18, 2016

testing 1 2 3

@durka
Copy link
Contributor Author

durka commented Oct 18, 2016

... 4 5 6

@durka durka merged commit 0a9c1e9 into DevProgress:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants