[#104] 새로운 온보딩 화면 작업 #109
Merged
[#104] 새로운 온보딩 화면 작업 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add Lottie JSON to Onboarding folder
- 특정 버튼 누르면 네이버 맵 앱으로 이동 - 네이버 맵 미설치인 경우, 앱스토어 링크로 연결
- 홈 화면에서 확인할 수 있는 info 뷰 수정 - 온보딩에 사용되는 변수와 구분하기 위해 변수명 변경(isShowingOnboarding -> isShowingInformation)
- 새로운 온보딩 화면 작업 - 온보딩 관련 변수명 변경 (hasSeenOnboarding -> shouldShowOnboarding)
Closed
5 tasks
|
|
||
| if let description = step.description { | ||
| Text(description) | ||
| .lineLimit(2) |
There was a problem hiding this comment.
여기 lineLimit이 사용된 이유는 무엇인가요?
There was a problem hiding this comment.
헉 불필요한 속성이었네요 .. 지우는 게 맞는 것 같습니댜. 수정할게요!
Comment on lines
52
to
+59
| #Preview { | ||
| OnboardingStepView(step: OnboardingStep.onboarding1) | ||
| OnboardingStepView(step: OnboardingStep.goNaverMap) | ||
| } | ||
| #Preview { | ||
| OnboardingStepView(step: OnboardingStep.capture) | ||
| } | ||
| #Preview { | ||
| OnboardingStepView(step: OnboardingStep.introFinish) |
There was a problem hiding this comment.
이거는 그냥 궁금한건데.. preview를 여러개 쓰면 여러개를 돌아가며 볼 수 있나요?
There was a problem hiding this comment.
이렇게 여러개로 확인 가능합니다 !
온보딩 케이스가 3개인데, 한 화면이 다르게 디자인 되어야 해서 비교하면서 보려고 선언해뒀어요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
Lottie라이브러리 설치했습니다.shouldShowOnboardingisShowingInformation스크린샷 (선택)