Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#138] BusStopData.csv 업데이트 반영하기 #139

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[#138] BusStopData.csv 업데이트 반영하기 #139

merged 1 commit into from
Dec 3, 2024

Conversation

Minkyeong-Choi
Copy link
Collaborator

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요

  • 기존에서 stopNameTranslated 열이 추가되었고, 그에 따른 변화사항을 등록하였습니다.
  • BusStop 모델에 stopNameTranslated 변수를 추가하였습니다.
  • Tooltip, bottom sheet, endView 모두에 stopNameNaver 대신 stopNameTranslated로 변경해놓았습니다.

스크린샷 (선택)

💬 리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 그 외 변경 사항으로 라이브액티비티의 stops left를 검정색으로 변경하였습니다.

@Minkyeong-Choi Minkyeong-Choi self-assigned this Dec 3, 2024
@Minkyeong-Choi Minkyeong-Choi linked an issue Dec 3, 2024 that may be closed by this pull request
BusStopData.csv 파일 작업하기 #138
Closed
4 tasks
dbqls200
dbqls200 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@dbqls200 dbqls200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셧씁니다

@dbqls200 dbqls200 merged commit ed5890a into dev Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbqls200 dbqls200 dbqls200 approved these changes

Assignees

@Minkyeong-Choi Minkyeong-Choi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BusStopData.csv 파일 작업하기
2 participants
@Minkyeong-Choi @dbqls200