[#12] 버스 루트 별 정류장 띄우기 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
dbqls200
reviewed
Oct 18, 2024
Comment on lines
92
to
96
| struct BusStop: Identifiable { | ||
| let id = UUID() | ||
| let name: String | ||
| let latitude: String | ||
| let longitude: String |
There was a problem hiding this comment.
기존에 사용하던 BusStopInfo와 차이점이 Identifiable와 id 뿐인 것 같은데, 따로 선언해서 사용하는 이유가 있나요 !
없다면 기존 구조체에 추가해서 사용하는 것도 좋을 것 같아요 :)
There was a problem hiding this comment.
수정했습니다! 확인 부탁드려요
dbqls200
reviewed
Oct 18, 2024
| @@ -75,23 +75,16 @@ final class BusStopSearchViewModel: ObservableObject { | |||
| } | |||
|
|
|||
| func getNameAndCoordinates(busNum: String) { | |||
There was a problem hiding this comment.
민~ 혹시 이 함수가, 사용자가 입력한 번호에 해당하는 정류장을 뽑아오는 함수인건가요~?
맞다면, BusSearchViewModel에 있는 searchBusStops 함수와 동일해 보이네요!
사용자가 입력한 버스 번호에 해당하는 정보는, BusSearchViewModel에 있는 filteredBusStops 변수에 접근해서 사용하면 돼요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
💬 리뷰 요구사항(선택)