[#29] CompletionCelebrationView 추가 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeonheebee
approved these changes
Nov 5, 2024
| @@ -58,5 +58,5 @@ struct CompletionReflectionView: View { | |||
| } | |||
|
|
|||
| #Preview { | |||
| CompletionReflectionView() | |||
| CompletionReviewView() | |||
There was a problem hiding this comment.
훨씬 네이밍이 직관적이어 졌어요(제 기준) 감사합니다 !
- 일관된 네비게이션 UX 제공을 위해 ViewModifier로 커스텀 백 버튼 구현 - 인터랙티브 pop 제스처 활성화를 위헤 UINavigationController delegate 설정 수정 (좌측 스와이프 시 이전 화면으로 이동)
- CompletionCelebrationView를 구현하여 사용자가 완독 메시지 확인과 소감 작성 페이지로 이동 가능
- 필요없는 주석을 제거합니다. - 리베이스 과정에서 지워진 코드를 추가합니다. (네비게이션 바 백 버튼 관련 코드)
zaehorang
force-pushed
the
feat/29--Completely-read-view
branch
from
4a7f4da to
f4da778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)