Confusion around meaning of name in Records and UI

[humphd]

A recent change has broken our code for string the name of a record in the db and UI.

In the example below, you can see an old record I created, which shows the full name (ignore the missing . which is #359). The second record shows only the subdomain part, and is missing the rest:

On staging, in the database, a similar thing is happening:

Is this related to @Genne23v's recent work to separate subdomain and fqdn? What should we be storing for name in the Records table (cc @cychu42).

[humphd]

I think the bug is in add-record-flow.server.ts:

export const addDnsRequest = async (data: AddDnsRequestData) => {
  const { username, type, subdomain, value } = data;

  const fqdn = buildDomain(username, subdomain);

  // Before running workflow. Add a record to DB
  const recordId = await createUserRecord({
    username,
    type,
    name: subdomain,           // <--- should this be `fqdn` instead?
    value,
  });

[humphd]

Or is the issue that the front-end needs to construct the fqdn from this subdomain + the user's baseDomain?

[Eakam1007]

If we are renaming the name column to subdomain (#377), maybe this should be done by front-end when displaying the records?

[humphd]

Yes, we can fix in front-end

[Myrfion]

@humphd As far as I understand this issue got resolved in #369, right?

[humphd]

Yes, we're good.