-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve domain name validation #233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Genne23v
added
category: DNS
A service about hosting domains
category: data
Anything related to data management and structure
labels
Feb 16, 2023
ghost
suggested changes
Feb 16, 2023
humphd
previously approved these changes
Feb 18, 2023
ghost
suggested changes
Feb 18, 2023
ghost
suggested changes
Feb 19, 2023
humphd
requested changes
Feb 19, 2023
ghost
approved these changes
Feb 19, 2023
humphd
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: data
Anything related to data management and structure
category: DNS
A service about hosting domains
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #185
Adding domain name validation as following rules
[name].[studentId].rootDomain.com(.)
-
, and_
-
-
or_
studentId
only contains alphanumerical charactersAlso domain name is lowercased before adding it to Route 53, but original name is stored in DB