Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DNS record renew button usability #431

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Improve DNS record renew button usability #431

merged 3 commits into from
Mar 24, 2023

Conversation

Eakam1007
Copy link
Contributor

Resolves #389

Changes

  • Moved renew button closer to expiry date
  • Added logic to disable renew button if DNS Record's expiry date is 6 months out or more

image

@Eakam1007 Eakam1007 added category: front end Front end part of our web service area: web Web development related things [front end/back end] category: DNS A service about hosting domains labels Mar 24, 2023
@Eakam1007 Eakam1007 requested a review from humphd March 24, 2023 05:17
@Eakam1007 Eakam1007 self-assigned this Mar 24, 2023
@Eakam1007 Eakam1007 requested review from Myrfion and Ririio March 24, 2023 05:18
@Eakam1007 Eakam1007 marked this pull request as ready for review March 24, 2023 05:24
humphd
humphd previously approved these changes Mar 24, 2023
View reviewed changes
Myrfion
Myrfion requested changes Mar 24, 2023
View reviewed changes
app/components/dns-records-table.tsx Outdated Show resolved Hide resolved
@Eakam1007 Eakam1007 requested review from humphd and Myrfion March 24, 2023 16:34
@Eakam1007 Eakam1007 merged commit 1344ad2 into DevelopingSpace:main Mar 24, 2023
@Eakam1007 Eakam1007 deleted the 389-record-renew-button-usability branch March 24, 2023 18:52
@Eakam1007 Eakam1007 mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myrfion Myrfion Myrfion approved these changes

@humphd humphd humphd approved these changes

@Ririio Ririio Awaiting requested review from Ririio

Assignees

@Eakam1007 Eakam1007

Labels
area: web Web development related things [front end/back end] category: DNS A service about hosting domains category: front end Front end part of our web service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve usability of record renew button
3 participants
@Eakam1007 @humphd @Myrfion