Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Adding Seneca Policy Link #492

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Conversation

Ririio
Copy link
Contributor

@Ririio Ririio commented Mar 31, 2023

Fixes #107

Added a link on landing page for Seneca IT Policy

Desktop
image

Mobile
image

@Ririio Ririio added category: front end Front end part of our web service area: web Web development related things [front end/back end] labels Mar 31, 2023
@Ririio Ririio added this to the Milestone 0.8 milestone Mar 31, 2023
@Ririio Ririio self-assigned this Mar 31, 2023
@Ririio Ririio requested review from Myrfion, Eakam1007 and humphd March 31, 2023 17:36
@@ -13,7 +13,7 @@ export const loader = async ({ request }: LoaderArgs) => {

export default function IndexRoute() {
return (
<VStack alignSelf="center" height="full">
<VStack alignSelf="center" height="94vh">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this magic number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove it, I had it set before to have a margin for the seneca policy text otherwise it will be too close to the cards, but I decided to go with padding instead

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Screenshot 2023-03-31 at 2 08 49 PM

If you want to do a thing where we add an About page (with details on how this was built by students, link to github, etc. file another issue). I think that's an interesting idea to consider.

@Ririio Ririio merged commit 92d9c0f into DevelopingSpace:main Mar 31, 2023
@Ririio Ririio deleted the issue-107 branch April 1, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: web Web development related things [front end/back end] category: front end Front end part of our web service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include link to Seneca's ITS Acceptable Use Policy in UI somehow
3 participants