Prevent duplicate CNAME for a user #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cychu42
added
category: DNS
Genne23v
requested changes
Apr 7, 2023
SerpentBytes
previously approved these changes
Apr 7, 2023
ghost
suggested changes
Apr 7, 2023
ghost
approved these changes
Apr 8, 2023
Genne23v
approved these changes
Apr 8, 2023
|
Thanks for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #442
This prevents duplicate CNAME records from the same user with the same name/
subdomain.Test
From our website, you can try to create multiple CNAME records with the same name/
subdomainas the same user.You should see an error that says "DNS Record already exists".