Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Certificate Instruction Page #565

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

Ririio
Copy link
Contributor

@Ririio Ririio commented Apr 11, 2023

This populates the route /certificate/instructions with actual information

Closes #293

@Ririio Ririio added the category: front end Front end part of our web service label Apr 11, 2023
@Ririio Ririio added this to the Milestone 1.0a milestone Apr 11, 2023
@Ririio Ririio requested review from humphd, Myrfion, Genne23v and a user April 11, 2023 15:04
@Ririio Ririio self-assigned this Apr 11, 2023
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the two "instruction" pages use the same layout, compare:

Screenshot 2023-04-11 at 11 08 19 AM

Let's do this:

  • left-align your main title vs. centre
  • add a Container to the DNS Instructions page to constrain the width like you do

I think they will be the same after this?

Add margin to the bottom of your Accordion so it's not so hard to use it at the bottom of the page.

There aren't any "instructions" on here, only info. Did you want to add a set of steps like the DNS page to tell people what they need to do?

@Ririio
Copy link
Contributor Author

Ririio commented Apr 11, 2023

There aren't any "instructions" on here, only info. Did you want to add a set of steps like the DNS page to tell people what they need to do?

Oh yeah when the route was created that was the idea, but it wasn't necessary, I'll change the route to specify it as information instead

add a Container to the DNS Instructions page to constrain the width like you do

Do you want to keep the current width of the text, but keep the entire container as left-aligned?

Here's the new layout

image

image

I also changed the route from "instructions" to "information" for the certificate

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these pages are way too wide. Yes, let's keep it left-aligned, but we don't need a container this wide for text. Text shouldn't be more than 15 words or so per line.

There needs to be some steps of how to get a certificate using our tool. Do something with steps like in the DNS Records page.

I don't understand this sentence:

Lastly, you can check the status of your SSL certificate by visiting SSL Shopper.

They can't check the status of their certificate using SSL Shopper. What does this mean?

This also makes no sense:

How long is an SSL Certificate valid for?

To find out more about this, it's best to get in touch with Seneca ITS as it all depends on their rules and regulations. They'll be able to provide you with the necessary information in this regard. You can contact them by clicking here

Let's Encrypt certificates are valid for 90 days.

under dns-records.

Can you use "DNS Records" like we do everywhere else? If you also want to link to that page, that's good too.

Under "What is a Certificate Authority" you should discuss that we use Let's Encrypt

@Ririio
Copy link
Contributor Author

Ririio commented Apr 11, 2023

Lastly, you can check the status of your SSL certificate by visiting SSL Shopper.

I may have worded it wrong, but it was meant for the user to use to check if their domain has valid certificate

Let's Encrypt certificates are valid for 90 days.

I'm a bit confused, but I'm referring here for the "expiration" date of the user's certificate, I recall the ITS people are the one who establishes this

Can you use "DNS Records" like we do everywhere else? If you also want to link to that page, that's good too.

Sure I'll refer to our page

@humphd
Copy link
Contributor

humphd commented Apr 11, 2023

Lastly, you can check the status of your SSL certificate by visiting SSL Shopper.

I may have worded it wrong, but it was meant for the user to use to check if their domain has valid certificate

This isn't clear from what you wrote.

Let's Encrypt certificates are valid for 90 days.

I'm a bit confused, but I'm referring here for the "expiration" date of the user's certificate, I recall the ITS people are the one who establishes this

ITS has nothing to do with this. It's a function of the length of the certificate that Let's Encrypt grants.

Maybe you're thinking of how long the domains last? That is arbitrary.

@Ririio
Copy link
Contributor Author

Ririio commented Apr 11, 2023

ITS has nothing to do with this. It's a function of the length of the certificate that Let's Encrypt grants.

Maybe you're thinking of how long the domains last? That is arbitrary.

Oh you're right, I may have confused dns-records expiration and certificate

app/components/certificate/description.tsx Show resolved Hide resolved
app/routes/__index/certificate/information.tsx Outdated Show resolved Hide resolved
app/routes/__index/certificate/information.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the same width treatment to the dns info page, so they match.

adding FAQ

Using FaqAccordion instead of list

change instruciton -> information for certificate

change faq info

resolve e2e test failure

change information link text to follow general format
@Ririio Ririio force-pushed the issue-293-certificate branch from 5b256b8 to 7358397 Compare April 11, 2023 17:21
@Ririio Ririio requested a review from Genne23v April 11, 2023 21:13
@humphd humphd merged commit 3419dde into DevelopingSpace:main Apr 11, 2023
@Ririio Ririio deleted the issue-293-certificate branch April 17, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: front end Front end part of our web service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put instructions for certificates
3 participants