notification issue in sim mode

[ituhin]

I had pushbullet notification on in the config, and i was running a sim with sar strategy,
and suddenly 100s of new tabs popped up in my chrome (with the location pushbullet.com). and it was keep on coming continuously. system became very slow and i had to force quit my chrome.

[emabo]

yes, because at the moment it sends notifications for each buy/sell op even if you are in sim mode. We can bind this behaviour to trade or paper running modes.

[ituhin]

yea. i would suggest trade mode only

[dsrikanth]

In zenbot/lib/engine.js, there are 3 places where notify.pushMessage happens. If the notify.pushMessage is wrapped inside a conditional statement (something like below), it will send notification only in live mode.

if (so.mode === 'live') {
  notify.pushMessage(......)
}

[emabo]

I would leave paper mode for testing and I think it's not necessary to put the condition at line 187, because a few lines before there was a return for all mode not equal to 'live'