This repository was archived by the owner on Feb 15, 2022. It is now read-only.
Add option to load previous trades #1243
Merged
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes DeviaVir#1239 This is an opt-in, either use `--use_prev_trades` or set `c.use_prev_trades = true` in conf.js If enabled we will load N of our previous trades within the time range of all previous trades (currently up to 1000) and use them for initial sell-stop triggers and loss protection. This way its no longer necessary to wait for a trade in a new session to get triggers/protection to fire, e.g. after a restart. The age of previous trades is limited so we don't accidentally end up with a stuck bot which isn't trading at all because the market moved too far since our last trade. All previous trades are exposed by the API in `my_prev_trades` and included in the dashboard under "My Trades" as "muted" trades at the bottom.
defkev
added a commit
to defkev/zenbot
that referenced
this pull request
Jan 30, 2018
DeviaVir
approved these changes
Jan 30, 2018
Heerpa
pushed a commit
to Heerpa/zenbot
that referenced
this pull request
Feb 25, 2018
* Add option to load previous trades Closes DeviaVir#1239 This is an opt-in, either use `--use_prev_trades` or set `c.use_prev_trades = true` in conf.js If enabled we will load N of our previous trades within the time range of all previous trades (currently up to 1000) and use them for initial sell-stop triggers and loss protection. This way its no longer necessary to wait for a trade in a new session to get triggers/protection to fire, e.g. after a restart. The age of previous trades is limited so we don't accidentally end up with a stuck bot which isn't trading at all because the market moved too far since our last trade. All previous trades are exposed by the API in `my_prev_trades` and included in the dashboard under "My Trades" as "muted" trades at the bottom. * Update README for DeviaVir#1243
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1239
This is an opt-in, either use
--use_prev_tradesor setc.use_prev_trades = truein conf.jsIf enabled we will load N of our previous trades within the time range of all previous trades (currently up to 1000) and use them for initial sell-stop triggers and loss protection.
This way its no longer necessary to wait for a trade in a new session to get triggers/protection to fire, e.g. after a restart.
The age of previous trades is limited so we don't accidentally end up with a stuck bot which isn't trading at all because the market moved too far since our last trade.
All previous trades are exposed by the API in
my_prev_tradesand included in the dashboard under "My Trades" as "muted" trades at the bottom.