This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Removed forward slash from assets #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to load the web ui from a subfolder on a domain the assets are not properly loaded due to the forward slash at the beginning. I noticed this when putting the GUI behind nginx proxy.
DeviaVir
approved these changes
Feb 14, 2018
DeviaVir
pushed a commit
that referenced
this pull request
Feb 19, 2018
* Removed forward slash from src Same reason as #1337 * Fixed chart not rendering Chart wouldn't render or call the trades API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to load the web ui from a subfolder on a domain the assets are not properly loaded due to the forward slash at the beginning. I noticed this when putting the GUI behind nginx proxy.