This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix binance product update #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2018 23:16
The function avoid code duplication and is more easily readable. Small behavior change: the new function accept products with both `min_size` and `min_total`. Previously, only the first one available was checked.
Changes with the previous version: - Binance filters are selected by type rather than by index. It fixes DeviaVir#1794 - No more useless removal of trailing zeros of 'increment' and 'asset_increment' - Binance notional filter is set in `product.min_total` rather than roughly modifying `product.min_size`. It fixes DeviaVir#1793
DeviaVir
reviewed
Dec 11, 2018
DeviaVir
approved these changes
Dec 11, 2018
This was referenced Mar 24, 2020
YarnSeemannsgarn
pushed a commit
to YarnSeemannsgarn/zenbot
that referenced
this pull request
Apr 15, 2020
* Engine: Split code about check of minimal order size into a function The function avoid code duplication and is more easily readable. Small behavior change: the new function accept products with both `min_size` and `min_total`. Previously, only the first one available was checked. * Binance: rewrite update-products to fix bugs Changes with the previous version: - Binance filters are selected by type rather than by index. It fixes DeviaVir#1794 - No more useless removal of trailing zeros of 'increment' and 'asset_increment' - Binance notional filter is set in `product.min_total` rather than roughly modifying `product.min_size`. It fixes DeviaVir#1793
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was far easier than I though: Poloniex already had the notional thing of Binance, but it was called min_total.
I've not tested to execute an order, but I've read it twice. It should not have any problem.
There are more details in the commit messages.