This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Restore onTrade() bail-out in a way that works #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix undoes #2334 and fixes the problem it tried to fix, the right way, by restoring bailing out of onTrade when an old trade comes in, but this time with the callback that went missing in the changes in 17e9758#diff-a41b519e7979a713e894ef8d1b3fe568R347-R349 . Because of the missing call on the callback function, the async queue chain would break when an old trade came in. This PR restores resuming operations when a trade comes in that belongs to a previous period. The bug, and these changes, affected only those running paper trades in very short timeframes such as 1s or 5s.
|
I've been banging my head on the code for weeks looking for this bug! Thank you thank you thank you! How did you find it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix undoes #2334 and fixes the problem it tried to fix, the right way, by restoring bailing out of onTrade when an old trade comes in, but this time with the call to the callback function which went missing in the changes in 17e9758#diff-a41b519e7979a713e894ef8d1b3fe568R347-R349 .
Because of the missing call on the callback function, the async event queue loop would break when an old trade came in. This PR restores resuming operations when a trade comes in that belongs to a previous period.
The bug, and these changes, affect only those running paper or live trading in very short timeframes such as 1s or 5s.