This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Update engine.js #2600
Merged
Update engine.js #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts commit DeviaVir#2425 and fixes the broken sim results
|
Could you elaborate, for future reference, why #2425 was bad and needed to be reversed? |
It seems the faking of the data, causes the calculation of the loss/profit to increase by 10 fold. This causes profit margins of around 400% in a sim of a few days. I don't exactly why it does this, as I was just looking for a fix, but I backtracked it to commit #2425 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts commit #2425 and fixes the broken sim results