This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Srsi macd #369
Merged
Srsi macd #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fasheng
reviewed
Jul 8, 2017
lib/sma.js
Outdated
| return sum + cur | ||
| }, 0) | ||
|
|
||
| s.period[key] = SMA / lenght |
|
Besides the typo, you could also rename the strategy name in backtester.js, too. |
|
can i fix the typo and re commit the pr? how can i fix it?
this happens a lot... screw the length
…On Sat, Jul 8, 2017, 2:33 PM fasheng ***@***.***> wrote:
Besides the typo, you could also rename the strategy name in
backtester.js, too.
Just rename all rsi_macd to srsi_macd:
sed -i 's/rsi_macd/srsi_macd/g' backtester.js
https://github.com/carlos8f/zenbot/blob/master/scripts/auto_backtester/backtester.js#L75
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#369 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALhf8mK8uEDCY5krSWuu2Asmyk1Phb6Fks5sL4UWgaJpZM4ORufw>
.
|
|
Yes, just edit the file and |
|
And you must edit |
fasheng
reviewed
Jul 8, 2017
lib/sma.js
Outdated
| let SMA = s.lookback | ||
| .slice(0, length) | ||
| .reduce((sum, cur) => { | ||
| return sum + cur |
There was a problem hiding this comment.
return sum + cur -> return sum + cur[source_key]
fasheng
approved these changes
Jul 8, 2017
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* updates to srsi_macd * rename strategy to srsi_macd * srsi_macd and sma indicator tweaks * fixed type in length * fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed and tweaked a bit the strategy and a small fix to the SMA file.