This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix for symmetrical option causing sim error #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By specifying `Boolean` in the declaration of the option, it caused an error by defaulting to `false`. If you tried to set it to `true` using `--symmetrical=true`, this would result in an error seen on issue DeviaVir#750. At this time there is still a bug with the symmetric code working.
DeviaVir
approved these changes
Nov 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specifying
Booleanin the declaration of the option, it caused an error by defaulting tofalse. If you tried to set it totrueusing--symmetrical=true, this would result in an error seen on issue #750. At this time there is still a bug with the symmetric code working.