This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix kraken products decimal precision in update-products.sh #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un increment for kraken products
storm1er
approved these changes
Dec 4, 2017
DeviaVir
reviewed
Dec 5, 2017
| @@ -1,352 +1,362 @@ | |||
| var KrakenClient = require('kraken-api'), | |||
There was a problem hiding this comment.
Did you mean to completely redo the indenting of this file?
There was a problem hiding this comment.
That's my fault on last commit on exchange.js on my fork, but this commit is not included in this pull request. Only update-products.sh and products.json should be merged.
Anyway, if you are interested in my fix for kraken connection error I'll fix the indenting asap
There was a problem hiding this comment.
ok :) this evening. I'll ping you when done
There was a problem hiding this comment.
Fixed indenting and
I tried to fix Issue #800 , please look at line 349 in exchange.js
order.price = n(orderData.price).format('0.00000000')
Tell me what you think about it :)
DeviaVir
approved these changes
Dec 5, 2017
| var public_client, authed_client | ||
| // var recoverableErrors = new RegExp(/(ESOCKETTIMEDOUT|ETIMEDOUT|ECONNRESET|ECONNREFUSED|ENOTFOUND|API:Invalid nonce|API:Rate limit exceeded|between Cloudflare and the origin web server)/) | ||
| var recoverableErrors = new RegExp(/(ESOCKETTIMEDOUT|ETIMEDOUT|ECONNRESET|ECONNREFUSED|ENOTFOUND|API:Invalid nonce|between Cloudflare and the origin web server|The web server reported a gateway time\-out|The web server reported a bad gateway|525\: SSL handshake failed)/) | ||
| var silencedRecoverableErrors = new RegExp(/(ESOCKETTIMEDOUT|ETIMEDOUT)/) |
There was a problem hiding this comment.
Sorry for that :( fixed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix automatic products generation. (update-products.sh)
Fix commit #757 that overwrote minimum increment for Kraken products
Restored changes in "Fix kraken products for krakens update on decimal precision #616"