Rest API Support for zenbot #797
Conversation
|
Can you give us an exemple about how to use your output extension ? =) This PR feels like "+16843214 up" ... You could split this in some PR next time ^^' |
| let run = function(reporter, tradeObject) { | ||
| if (!reporter.port || reporter.port === 0) { | ||
| random_port({from: 20000}, function(port) { | ||
| startServer(port, tradeObject) |
There was a problem hiding this comment.
try/catch if the port doesn't work, and we try a different one automatically?
There was a problem hiding this comment.
okay I will do that
There was a problem hiding this comment.
the random_port function already searches for a free port, so I dont think this is neccesary anymore. The function also tests explicitly if the port is available through a try / catch mechanism
There was a problem hiding this comment.
Ah, sweet! Thanks for digging that up.
extensions/output/api.js
Outdated
| let startServer = function(port, tradeObject) { | ||
| tradeObject.port = port | ||
|
|
||
| app.get('/tradedata', function (req, res) { |
There was a problem hiding this comment.
agreed, I'll change that
extensions/output/api.js
Outdated
| }) | ||
|
|
||
| app.listen(port) | ||
| tradeObject.url = require('ip').address() + ':' + port + '/tradeData' |
|
@storm1er the output extension works the same as the notifiers, exchanges and strategies extensions. For that reason I did not add any manual for it. With regards to the rest api. The config-sample.js should be self explanatory. I will add the available url and path names in a readme. Also, I do not know how I can split this pull request even further, all it contains is REST api support for zenbot. |
|
Seems that REST API requires two ports. If I put a single port in the config the app crashes a start. Could you give me a working config example ? |
|
@albabosh I don't have any issues with this PR, |
|
If I enable REST API in conf.js & set c.output.api.port = 20002 it crashes a start (seems that express tries to bind twice to one port). I I set c.output.api.port = 0 zenbot starts well and binds to 2 random ports. I need to specify those two ports in confg (not random) |
|
hmm That's weird ... I didn't need have this problem ... Didn't need to manually set port anyway ^^' |
Hi guys,
Here is the code, that enables zenbot to have a REST API.
I tried to keep the code extendable, by allowing zenbot to add multiple outputs (one of them is this REST API). I have other outputs available like storing the trade in AWS dynamoDB.
I also think it would be a good idea to refactor the stdout reporting part of zenbot, so that would also become an output.
Please let me know if you have any questions.