This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix market order actual price #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In market order the actual price (api_order.price) should be very different from trade price
DeviaVir
reviewed
Dec 12, 2017
lib/engine.js
Outdated
| @@ -293,6 +293,7 @@ module.exports = function container (get, set, clear) { | |||
| msg('order status: ' + order.status) | |||
| if (api_order.status === 'done') { | |||
| order.time = new Date(api_order.done_at).getTime() | |||
| order.price = api_order.price || order.price // Use actual price if possibile. In market order the actual price (api_order.price) should be very different from trade price | |||
There was a problem hiding this comment.
In market order the actual price (api_order.price) should be very different from trade price should be or could be?
There was a problem hiding this comment.
Could be*, and very often is :)
DeviaVir
approved these changes
Dec 12, 2017
Fix comment
DeviaVir
approved these changes
Dec 12, 2017
This was referenced Mar 24, 2020
This was referenced Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In market order the actual price (api_order.price) should be very different from trade price
Use actual price if possible.
This should fix issue #800