Allow all streams in client.push() & client.install() types, not just FS streams #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimterry
force-pushed
the
fix-client-push-stream-type
branch
from
41eb53f
to
286318c
Compare
Signed-off-by: Tim Perry <tim@httptoolkit.com>
pimterry
force-pushed
the
fix-client-push-stream-type
branch
from
286318c
to
e75f211
Compare
|
(Force pushed to fix the commit sign-offs so the CI tests pass) |
koral--
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type used in
pushandinstallfor device clients isn't quite right: it only accepts FS streams, meaning you can't stream data from anywhere but the disk. The underlying sync APIs do support any streams though, so we just need a tiny change to widen the types to allow this.