Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move off screen password autofill #610

Conversation

Ristakis
Copy link

@Ristakis Ristakis commented Nov 1, 2022

Using css moved off screen the password autofill form when trying to use keyboard

@Ristakis Ristakis force-pushed the feature/move-password-autofill-form-off-screen branch from 432f3f5 to afd6252 Compare November 1, 2022 15:18
@koral--
Copy link
Member

koral-- commented Nov 1, 2022

What kind of problem does it solve?

@Ristakis
Copy link
Author

Ristakis commented Nov 1, 2022

image

It moves this box out of the screen

@Ristakis Ristakis force-pushed the feature/move-password-autofill-form-off-screen branch from afd6252 to 20dc091 Compare November 1, 2022 17:04
@koral--
Copy link
Member

koral-- commented Nov 1, 2022

How to reproduce it?

@Ristakis
Copy link
Author

Ristakis commented Nov 1, 2022

How to reproduce it?

You have to have at least 1 saved password (chrome feature) to be able to reproduce

Steps to reproduce:
Open any android device,
Focus any input,
Start typing with your keyboard (not device keypad)

This happens because the input that catches the events is of type password, and chrome wants to fill it with your saved passwords.

@Ristakis
Copy link
Author

Ristakis commented Nov 2, 2022

@koral-- Did you have time to review this?

@koral--
Copy link
Member

koral-- commented Nov 3, 2022

I could not reproduce that. On which browser does it happen?

Signed-off-by: Riste <rsamardjiev@playtika.com>
@Ristakis Ristakis force-pushed the feature/move-password-autofill-form-off-screen branch from 20dc091 to 2f8daf5 Compare November 3, 2022 08:50
@Ristakis
Copy link
Author

Ristakis commented Nov 3, 2022

@koral-- google chrome

@elenkuz
Copy link

elenkuz commented Nov 3, 2022

I have the same issue with autofill form

@ZhyliaievD
Copy link

Same here - face it from google chrome
To reproduce - send some keystrokes to the device(e.g. type in text field) OR use arrow UP/DOWN(I use it for navigation in some cases)

@koral--
Copy link
Member

koral-- commented Nov 3, 2022

ok,got it

@koral-- koral-- merged commit f168b45 into DeviceFarmer:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants