On channel watch error, set channel offline and try another

[imranh2]

Basically the title.

I had an issue where 1 channel "channel":"multiversus","channel_id":735931830 was causing me issues due to "error":"Content+Restricted+In+Region","error_code":"content_geoblocked","type":"error" and the whole app would just stop...

Bit of a hack as this will keep trying channels until it finds no more, but is that such a bad thing?

[DevilXD]

The problem is, set_offline won't work, because the viewer's update will set it back online like 1-2 minutes later. There's currently no solution nor way to "mark a channel as unwatchable, even if it's online". You'll need to exclude the game that causes this channel to appear, or edit the code to exclude this particular channel out.

I've expected this will appear sooner or later after I've pushed the last commit, but for now, cases like this are only reported as errors, but not handled.

[imranh2]

It's not just reported, the whole app stops due to exception handling.

It works pretty well for me, a channel fails due to whatever reason, gets marked as offline, and a new channel is picked. The state of the channel changing back to online isn't actually a issue becuase the miner doesn't switch to it.

Hard failing on a resolvable error in a program that you're supposed to let idle/run in the background? There's better ways than this...

[DevilXD]

It's not just reported, the whole app stops due to exception handling.

Read my response under the actual issue here: #586 (comment)
The commit has been pushed: 3b4923a

The state of the channel changing back to online isn't actually a issue becuase the miner doesn't switch to it.

It will switch to it, if the channel is found to be of higher priority. That will happen if the channel being set online is the only channel for a higher priority game. This PR is not a fix for the issue in any remote way, and I won't accept it.

Hard failing on a resolvable error in a program that you're supposed to let idle/run in the background? There's better ways than this...

You are welcome to use a different software, or familiarize yourself with the project goals, where it's clearly stated that the errors are expected and will happen: https://github.com/DevilXD/TwitchDropsMiner#project-goals
The logic will need to be adjusted so that a channel can be marked as not possible to be watched when that happens.

[imranh2]

I missed your comment! I apologise.

The idea of unwatchable streams makes the most sense.