Fix unhandled exception for games with >400 channels #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2022 13:38
Since it won't run without it
Rather than hanging and becoming unresponsive due to an unhandled exception
|
Hmm, right. Looks good, thank you =) |
DevilXD
pushed a commit
that referenced
this pull request
Apr 26, 2023
Fork Sync: Update from parent repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websocket.add_topics throws if it is given more than 400 topics (8 websockets * 50 topics per ws).
The current Lost Ark campaign has more valid channels than this and would cause the client to instantly freeze/crash on startup due to the "Maximum topics limit has been reached" exception.
This PR simply catches and ignores the exception.