Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/i18n #367

Merged
merged 16 commits into from
Jun 4, 2024
Merged

Feature/i18n #367

merged 16 commits into from
Jun 4, 2024

Conversation

eric-burel
Copy link
Contributor

@eric-burel eric-burel commented May 16, 2024

  •  Migrate Next.js surveyform to new system
  •  Test the experimental stuff developed for astro results on Next
  • "ServerT" using a server-only-context (via React cache) similar to "T.Astro". Work in progress but could display a first token! The implementation is particularly tricky if not super familiar with React Server Components. But that's how ti is.
  • Assess whether a React Server Component actually have any kind of benefit on performance? The main benefit seems to be that server-side we don't need to filter out unused token to minimize the dictionary size, so we don't have to collect tokens for these server-rendered translation. But if your token collection system becomes powerful enough the benefit is limited.
  • fetch pipeline => now returning {data, error} rather than throwing, added helpers and a default system, seems ok
  •  Use children as default values
  •  Figure using an array of strings from API vs a map of strings with token as key client-side => ok but still have to figure t/tHtml
  • Remove all dead code, support all features
  • Unifiy with Astro/make a shared package.

Will need to dig this discussion about RSC data ending up in the HTML code: vercel/next.js#42170

See similar effort at Lingui: lingui/js-lingui#1698

Copy link

render bot commented May 16, 2024

Copy link

netlify bot commented May 16, 2024

Deploy Preview for devographics-graphiql2 canceled.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql2/deploys/664622848b221e000846a0b1

Copy link

netlify bot commented May 16, 2024

Deploy Preview for stateofjs2022 failed.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs2022/deploys/6646228495b93a00087aff2a

Copy link

netlify bot commented May 16, 2024

Deploy Preview for devographics-static failed.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/devographics-static/deploys/66462284b38698000823dd4b

Copy link

netlify bot commented May 16, 2024

Deploy Preview for stateofjs canceled.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/stateofjs/deploys/664622849df18e0008048141

Copy link

netlify bot commented May 16, 2024

Deploy Preview for graphiql-devographics canceled.

Name Link
🔨 Latest commit 4e70e1d
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-devographics/deploys/665de061488dbb00082f9eb3

Copy link

netlify bot commented May 16, 2024

Deploy Preview for tokyodev2022 failed.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/tokyodev2022/deploys/6646228447256b0008b80822

Copy link

netlify bot commented May 16, 2024

Deploy Preview for state-of-graphql canceled.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/state-of-graphql/deploys/66462284ef27880008c517f5

Copy link

netlify bot commented May 16, 2024

Deploy Preview for css2023 failed.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/css2023/deploys/66462284cbbed70008c31bf6

Copy link

netlify bot commented May 16, 2024

Deploy Preview for devographics-graphiql-internal canceled.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/devographics-graphiql-internal/deploys/66462284c1970b00085b5c3d

Copy link

netlify bot commented May 16, 2024

Deploy Preview for stateofcss canceled.

Name Link
🔨 Latest commit 3fead1d
🔍 Latest deploy log https://app.netlify.com/sites/stateofcss/deploys/6646228413354500085c41a3

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
charts ❌ Failed (Inspect) Jun 3, 2024 3:28pm
results-astro ❌ Failed (Inspect) Jun 3, 2024 3:28pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant