fix(cliprdr-native): handle WM_ACTIVATEAPP in clipboard_subproc
#657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds handling of `WM_ACTIVATEAPP` in `clipboard_subproc`. Previously, the function handled only `WM_ACTIVATE`. MSDN references: * WM_ACTIVATE: https://learn.microsoft.com/ru-ru/windows/win32/inputdev/wm-activate ( WM_ACTIVATEAPP: https://learn.microsoft.com/en-us/windows/win32/winmsg/wm-activateapp As you can see from the general description they are quite similar. During the tests, I was only receiving `WM_ACTIVATEAPP.` To investigate the issue I went to see how Windows handles them. I found that Windows just straight-up handles those messages as they are the same: * https://github.com/tongzx/nt5src/blob/daad8a087a4e75422ec96b7911f1df4669989611/Source/XPSP1/NT/shell/comctl32/v6/prsht.c#L3873-L3887 * https://github.com/tongzx/nt5src/blob/daad8a087a4e75422ec96b7911f1df4669989611/Source/XPSP1/NT/shell/comctl32/v5/prsht.c#L3954-L3968 * https://github.com/tongzx/nt5src/blob/daad8a087a4e75422ec96b7911f1df4669989611/Source/XPSP1/NT/multimedia/dshow/filters/image/video/window.cpp#L176-L203 * https://github.com/tongzx/nt5src/blob/daad8a087a4e75422ec96b7911f1df4669989611/Source/XPSP1/NT/base/mvdm/tools/c932/inc/scrnsave.h#L96-L106
RRRadicalEdward
requested review from
CBenoit and
pacmancoder
and removed request for
CBenoit
Coverage Report 🤖 ⚙️Past: New: Diff: -0.01% [this comment will be updated automatically] |
CBenoit
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling of
WM_ACTIVATEAPPinclipboard_subproc. Previously, the function handled onlyWM_ACTIVATE. MSDN references:During the tests, I was only receiving
WM_ACTIVATEAPP.To investigate the issue I went to see how Windows handles them. I found that Windows just straight-up handles those messages as they are the same:The bug is in IronVNC repo - https://github.com/Devolutions/IronVNC/issues/687