Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 137 Fix the response format in the delete and purchase endpoints #138

Merged
merged 8 commits into from
Dec 8, 2020

Conversation

yuhanzz
Copy link
Member

@yuhanzz yuhanzz commented Dec 8, 2020

  1. Added JSON format error handlers and test cases
  2. Prevented data validation error caused by deserialize() in update endpoint since we support partial update
  3. Added checking for any missing parameter in purchase endpoint
  4. Fixed JS code to prevent calls to api/products/ when product id is empty
  5. Changed response of purchase endpoint to JSON format

note: the 415 handler can not be covered by test case because of spec-first/connexion#854

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #138 (5ca0f6d) into master (7154cc8) will decrease coverage by 0.52%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   99.45%   98.93%   -0.53%     
==========================================
  Files           2        2              
  Lines         364      374      +10     
==========================================
+ Hits          362      370       +8     
- Misses          2        4       +2     
Impacted Files Coverage Δ
service/service.py 98.35% <94.87%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7154cc8...5ca0f6d. Read the comment docs.

@xz2643 xz2643 merged commit 1f632bf into master Dec 8, 2020
@xz2643 xz2643 deleted the issue137-fix_response_format branch December 8, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants