Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow mocked.On("X").Return(func(a Arguments) Arguments { return nil }) #4

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

gburt
Copy link

@gburt gburt commented Feb 23, 2021

I've submitted this upstream at stretchr#742 but in 2 years they haven't even commented on it

Copy link

@nik-andreev nik-andreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will make mocking functions that return functions harder, but I don't think we have this problem.

@gburt gburt merged commit 20dee70 into DevotedHealth:master Feb 23, 2021
@gburt
Copy link
Author

gburt commented Feb 23, 2021

I guess this will make mocking functions that return functions harder, but I don't think we have this problem.

Not much harder - it pattern matches against the given func, and ignores things that don't have the right signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants