Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curated first names and company names for the French locale #81

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Curated first names and company names for the French locale #81

merged 1 commit into from
Mar 29, 2017

Conversation

ccjmne
Copy link
Contributor

@ccjmne ccjmne commented Mar 29, 2017

Hey,
Thanks for this project -- it's pretty useful!

In the French locale file, some information is suspicious/inexact. I manually curated that data a bit, considering the following:

  • some company names lack mandatory accentuation on common nouns
  • some company names look like they contain bits that were intended to be entirely capitalised (e.g.: "Abc Something" would become "ABC Something")
  • some names listed as male are exclusively female
  • 3 random words slipped into the female names list:
    • "ses", meaning "his/her" (plural)
    • "dérivés", meaning "derivated" (male, plural)
    • "composés", meaning "composed" (male, plural)

I don't like pushing directly on the master branch but... that's just it. The rest of the data looks just fine and there isn't any breaking change... whatsoever. Let me know if there's anything I should do differently.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 20851de on ccjmne:master into ** on Codearte:master**.

Copy link
Contributor

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szpak szpak merged commit a5fe958 into Devskiller:master Mar 29, 2017
@szpak
Copy link
Contributor

szpak commented Mar 29, 2017

Thanks for your contribution!

@ccjmne
Copy link
Contributor Author

ccjmne commented Mar 29, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants