-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.9.0rc #313
Open
mdeshotel
wants to merge
26
commits into
main
Choose a base branch
from
release/0.9.0rc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release/0.9.0rc #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release/0.8.3
Fix handling of unsteady flows simulations in source model
Check RAS units are English
Add xs_overtopped column to rating curve db
Feature/model name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature-release 0.9.0rc
Summary
This PR adds checks for both source HEC-RAS model units and whether the source HEC-RAS model is an unsteady model. If the source model units are not
English
then an error is raised because rippl1d only supportsEnglish
units. If the source model was an unsteady model then an error is raised as ripple1d only supports steady state 1d HEC-RAS source models.This PR also includes updates to the 2 endpoints.
Conflate_model
andcompute_conflation_metrics
now require amodel_name
arg. This was added so that the geopackage file did not have to be inferred from the directory/directory name. Now the geopackage name is derived from combining thesource_model_directory
arg and themodel_name
arg.Lastly, this PR adds a flag in the rating curve database for when a plan/profile overtops one of the cross sections in the model. The column for this boolean is named
xs_overtopped
.Features Added
Check Units
The source HEC-RAS model (and thus the derived submodel) must have units of
English
. If it does not then an error is raised in thecreate_model_run_normal_depth
endpoint. To do this several additional changes had to be made to the schema.units
is now passed from the source_model.gpkg to the conflation.json duringconflate_model
.source_model_metadata
is now passed from the conflation.json to the ripple1d.json duringextract_submodel
.units
andsteady
(which is a boolean indicating if the source model was steady state) is now passed from the conflation.json to the submodel.gpkg duringextract_submodel
. This required adding a new metadata table to the submodel.gpkg.create_model_run_normal_depth
reads the ripple1d.json and raises an error ifunits
is notEnglish
.Handle Unsteady Source Model
The handling of unsteady flow files in the source RAS model has been updated. Unsteady RAS models can now be extracted for cataloging purposes without error. However, it was decided that unsteady 1d models should not be processed through ripple1d as a steady state model and so an error is raised during
create_model_run_normal_depth
if theforcing file extension
from the source model does not containsf
indicating that it is not a steady state model.Identify Overtopped Cross Sections
A column named
xs_overtopped
has been to the rating curve database which indicates if any cross sections were overtopped for any plan/profile. This should help to identify when a FIM should be scrutinized, discarded, or other decision made with regards to how it should be interpret it.Add Model Name as arg
A required arg,
model_name
has been added to theconflate_model
andcompute_conflation_metrics
endpoint. This enables the the user to specify the name of the model instead of inferring it from the model directory name which was not full proof.closes #186
closes #303
closes #123
closes #176