Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3 fields to certificate parsing #120

Merged
merged 3 commits into from
Apr 27, 2017
Merged

add 3 fields to certificate parsing #120

merged 3 commits into from
Apr 27, 2017

Conversation

TatyanaBol
Copy link
Contributor

Dear Josef
We are happy to find your package that implement all requirements we need to parse and validate SSL certificate in PEM format. It's very clear and convenient.
The only thing we miss here is 3 certificate's fields - signatureAlgorithm, publicKeyAlgorithm and publicKeySize. Please add them to the implementation of fetchCertificateData.

Thanks in advance,
Tatyana Bolshinsky
Senior Software Developer
IBM Cloud Security Team

@Dexus
Copy link
Owner

Dexus commented Apr 27, 2017

Dear Tatyana,
I'm happy to read that you are happy with this package.

I thank you for your PR. Feel free to open an other PR for your needs.

Regards,
Josef Fröhle

@Dexus Dexus merged commit 7391c5d into Dexus:master Apr 27, 2017
@TatyanaBol
Copy link
Contributor Author

Dear Josef
Thank you for your answer.
When are you planning to publish a new version to npm?
We can use your package only from there.

Best regards,
Tatyana

@Dexus
Copy link
Owner

Dexus commented Apr 27, 2017 via email

@TatyanaBol
Copy link
Contributor Author

Nice!!
Thanks!
Tatyana

@Dexus
Copy link
Owner

Dexus commented May 4, 2017

@TatyanaBol released sorry for the delay

@TatyanaBol
Copy link
Contributor Author

Thanks!

@TatyanaBol
Copy link
Contributor Author

TatyanaBol commented May 7, 2017

Hi
I found a problem with parsing Public Key Size in different OS.
Apparently openssl works differently and the field looks different.
On my Mac it looks 'RSA Public key: (2048 bit)'.
On Linux machine it looks like 'Public-Key: (2048 bit)'.
So I changed a little parsing for this field.
Please review and merge my Pull Request

Tatyana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants