add 3 fields to certificate parsing #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Josef
We are happy to find your package that implement all requirements we need to parse and validate SSL certificate in PEM format. It's very clear and convenient.
The only thing we miss here is 3 certificate's fields - signatureAlgorithm, publicKeyAlgorithm and publicKeySize. Please add them to the implementation of fetchCertificateData.
Thanks in advance,
Tatyana Bolshinsky
Senior Software Developer
IBM Cloud Security Team