Code review

DiSSCo · Oct 28, 2024 · 1fccaf5 · 1fccaf5
1 parent 1376d13
commit 1fccaf5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -28,13 +28,6 @@ jobs:
       - name: Build image
         run: |
           docker build -t $REPO_LC data-model/
-      - name: Trivy - List all vulnerabilities
-        uses: aquasecurity/trivy-action@master
-        with:
-          image-ref: ${{ env.REPO_LC }}
-          format: 'table'
-          ignore-unfixed: true
-          vuln-type: 'os,library'
       - name: Trivy - List all vulnerabilities
         uses: aquasecurity/trivy-action@master
         with:

diff --git a/data-model/developer-schema/annotation/0.4.0/schema/annotation-batch-metadata.json b/data-model/developer-schema/annotation/0.4.0/schema/annotation-batch-metadata.json
@@ -29,7 +29,8 @@
         "required": [
           "inputField",
           "inputValue"
-        ]
+        ],
+        "additionalProperties": false
       },
       "minItems": 1
     }

diff --git a/...er-schema/machine-annotation-service/0.4.0/schema/machine-annotation-service-request.json b/...er-schema/machine-annotation-service/0.4.0/schema/machine-annotation-service-request.json
@@ -174,7 +174,7 @@
     "ods:containerImage",
     "ods:containerTag",
     "ods:batchingPermitted",
-    "ods:TargetDigitalObjectFilter"
+    "ods:hasTargetDigitalObjectFilter"
   ],
   "additionalProperties": false
 }
diff --git a/data-model/developer-schema/source-system/0.4.0/schema/source-system-request.json b/data-model/developer-schema/source-system/0.4.0/schema/source-system-request.json
@@ -62,9 +62,9 @@
   },
   "required": [
     "schema:name",
-    "schema:uri",
+    "schema:url",
     "ods:translatorType",
-    "ods:mappingID"
+    "ods:dataMappingID"
   ],
   "additionalProperties": false
 }