Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ukrainian entries to yml #271

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Conversation

sturman
Copy link
Contributor

@sturman sturman commented Dec 11, 2017

No description provided.

@codingricky
Copy link
Contributor

Any chance you could put the PR into the ruby version of the faker gem? https://github.com/stympy/faker/blob/master/lib/locales/uk.yml And then I'll copy it over as tend to sync the yml files between this project and that one.

@sturman
Copy link
Contributor Author

sturman commented Jan 17, 2018

@codingricky codingricky merged commit 54919f5 into DiUS:master Jan 17, 2018
rolyatwilson pushed a commit to rolyatwilson/java-faker that referenced this pull request Apr 23, 2018
* add music instruments

* added artist

* added Yoda quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants