Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow insecure connections on 127.0.0.1 #118

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

surpher
Copy link
Contributor

@surpher surpher commented Feb 4, 2021

For some yet-unknown reason URLSessionDelegate isn't called if the baseURL is set to https://localhost.
Adding 127.0.0.1 and 0.0.0.0 to the allow list when trying to connect over SSL where provider is exposing its endpoints using a self-signed certificate. This will enable users to actually set up the mockService and .run() the Pact tests against mock-server.

This way mockService can be instantiated with using:

PactVerificationService(url: "https://127.0.0.1", port: 1234, allowInsecureCertificates: true)

This was raised in #114

@surpher surpher merged commit c5e8324 into DiUS:master Feb 5, 2021
@surpher surpher changed the title chore: Allow non-secure connections on 127.0.0.1 chore: Allow insecure connections on 127.0.0.1 Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants