Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/native wrapper pr #50

Closed
wants to merge 183 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
183 commits
Select commit Hold shift + click to select a range
8bc8fc0
Create Brewfile
stephengroat Jan 4, 2018
db7abe5
move to brew bundle
stephengroat Jan 4, 2018
3e1edc3
move to brew update
stephengroat Jan 5, 2018
38d5055
Merge pull request #34 from stephengroat/patch-1
Feb 7, 2018
b538409
wait on verify to complete before allowing tests to continue to preve…
Apr 24, 2018
26cab90
Update BrightFutures
Apr 25, 2018
c7d1ed5
Merge pull request #37 from rvoortman/update-bright-futures
andrewspinks Apr 25, 2018
6749fdc
Merge pull request #38 from stitchfix/master
andrewspinks May 1, 2018
2bc59b5
Update gems
andrewspinks May 8, 2018
52cf980
Update release script to work better with cocoa pods
andrewspinks May 8, 2018
2b4f5e0
update changelog for release 0.5.2
andrewspinks May 8, 2018
5ec6eb3
bump cocoapods version to 0.5.2
andrewspinks May 8, 2018
2a667c2
Updates README to encourage usage of pact-ruby-standalone
surpher May 16, 2018
e1c4596
Removed reference to non-standalone pact mock service
surpher May 18, 2018
58387dd
Merge pull request #40 from surpher/master
andrewspinks May 18, 2018
d639fe7
Update readme
surpher Jan 23, 2019
6ca5c37
Update BrightFutures dependency version
surpher Jan 23, 2019
0e7212b
Project updates for Swift 4.2
surpher Jan 23, 2019
5897e28
Updates travis pipeline to run tests on iOS 12.1 and 11.3
surpher Jan 23, 2019
4198e38
Bump up Alamofire version
surpher Jan 23, 2019
8c4d3cf
Bumps up versions of all dependencies
surpher Jan 23, 2019
596b6b8
Update travis CI env matrix
surpher Jan 23, 2019
f8899f8
Update Quick dependency to use “master”
surpher Jan 23, 2019
2e77868
Update Cartfile.resolved for use with bootstrap on CI
surpher Jan 23, 2019
f2f4ec7
Merge pull request #42 from surpher/master
andrewspinks Jan 24, 2019
5ebc062
Update pact-mock-service versions
andrewspinks Jan 24, 2019
a1cd000
Update cocoapods dependencies.
andrewspinks Jan 24, 2019
c4d696b
update changelog for release 0.5.3
andrewspinks Jan 24, 2019
3db2587
bump cocoapods version to 0.5.3
andrewspinks Jan 24, 2019
28e1588
Fix cocoa pods release version number and release script.
andrewspinks Jan 24, 2019
3ed97f1
Update dependencies
georgescumihai Mar 25, 2019
753a36a
Merge pull request #44 from georgescumihai/feature/update-dependencies
andrewspinks Mar 26, 2019
581ee68
Merge branch 'master' into feature/nativeWrapper
May 4, 2019
cd51034
synced Cartfile, SPM, podspec dependencies and versions
May 4, 2019
8ad91b9
resolved dependencies to work
May 4, 2019
aac72c7
fixed swift linter errors
May 4, 2019
9bb0ab7
removed result framework references from project file
May 4, 2019
66721ef
updated swiftlint version
May 4, 2019
c96241e
updated project to swift 5.0
May 4, 2019
de83bc5
updated libpact_mock_server.a
May 4, 2019
3d2671e
* made NativeMockServerWrapper usable
May 4, 2019
687db85
* using the native matcher instead of the ruby matcher
May 4, 2019
02ad112
making sure the pact_mock_server header and binary are with the pod
May 4, 2019
9debdf3
* reverted matcher override
May 6, 2019
04e70a4
* simple solution to set the matcher
May 6, 2019
f99eda6
updated libpact_mock_server.a (was built with: cargo lipo --release -…
May 6, 2019
5f1616e
updated libpact_mock_server.a to inclued arm64 as well (current targe…
May 6, 2019
b5b6e6d
enabled user to set custom port to prevent collision for multiple ins…
May 6, 2019
5b6bda8
* added handling for errors on write
May 9, 2019
aead22b
fixed crashes by returning on occuring errors
May 9, 2019
45878a9
gracefully handling non-existent directories
May 9, 2019
75859ad
* removed port setting ability from initializer
May 10, 2019
d1f16af
added some debug output
May 10, 2019
a851de6
show info on cleanup
May 10, 2019
06e9f4a
* added notify debug message if folder not found
May 13, 2019
220feb9
added logic to create pact path
May 13, 2019
d157963
cleaned writing errors a bit
May 14, 2019
9a5df7c
introduced possibility to append interactions to pact
May 15, 2019
67ef810
introduced flag to decide if pact should be written
May 15, 2019
ca86d56
minor changes to pact dir setting and error message text
May 15, 2019
1af6e69
* fixed not waiting for verification while running pact test
May 20, 2019
6ab1eab
removed FIXMEs
May 28, 2019
f0fb433
removed Result framework from Carthage scripts in test targets
May 28, 2019
017ee95
adjusted iOS version in build script
May 28, 2019
e393f9b
fixed warning
May 28, 2019
2273ce8
fixed warning
May 28, 2019
80c3a48
added constructor with default matcher (to not break tests)
May 28, 2019
84952f5
removed extended file writing logic
Jun 3, 2019
be951a4
added order for dictionary keys (for the tests)
Jun 3, 2019
8a53233
added MinTypeMatcher
Jun 6, 2019
f89027c
added and adjusted to MinTypeMatcher changes
Jun 6, 2019
86b3b59
using MinTypeMatcher in PactBodyBuilder
Jun 6, 2019
46169a1
add body of MinTypeMatcher multiple times
Jun 6, 2019
20591fe
removed warning
Jun 7, 2019
b7305a4
adapted and added test for minType rule
Jun 7, 2019
23a0f84
updated fastlane
Jun 7, 2019
805d100
updated query test to pass
Jun 7, 2019
fb647e3
updated CONTRIBUTING.md
Jun 7, 2019
417ba24
moved swift version to podspec
Jun 7, 2019
98cc356
added individual libraries for mac os and ios
Jun 7, 2019
3937764
synced ios versions for default tests
Jun 7, 2019
12600ae
fixed target selection
Jun 7, 2019
8ce1b01
split up libs more
Jun 7, 2019
4d28901
moved lib files and added combine and copy scripts
Jun 7, 2019
4fd4205
added SwiftyJSON as dependency to SPM
Jun 7, 2019
d39c744
point to current directory to satisfy pod spec lint
Jun 7, 2019
cdfc34d
trigger commit
Jun 7, 2019
6917fff
set swift version to 4.2 because 5.0 failed on travis
Jun 7, 2019
aeb27e0
faster builds first
Jun 7, 2019
af7db06
adjusted all targets to swift version 4.2
Jun 7, 2019
188862a
Revert "trigger commit"
Jun 7, 2019
9be3bb1
increased xcode version and added swift version download
Jun 7, 2019
cf390bf
readded swift 5 versions
Jun 7, 2019
c78c673
removed install step
Jun 7, 2019
da8ddb8
added bundle update
Jun 7, 2019
289bc8a
recommended way of updating bundler
Jun 7, 2019
9843a58
readded xcpretty to Gemfile
Jun 7, 2019
2984711
adjusted header search path in podspec
Jun 7, 2019
1a3f7b6
removed duplicate header
Jun 7, 2019
23296ce
Completely removed Alamofire in favor of simple networking calls. (#51)
macblazer Jun 12, 2019
8688fdc
Refactor pact mock server network calling code and upgrade to swift 5…
surpher Jun 19, 2019
848f4c5
Remove quick dependency from requirements. It is only used for intern…
andrewspinks Jun 23, 2019
cdecfbc
Fixes bitcode related issue when used from CocoaPods.
macblazer Jun 24, 2019
f00421a
Merge pull request #60 from macblazer/feature/fix-bitcode
surpher Jun 25, 2019
9605227
Cleanup build settings so ci build can be more easily reproduced loca…
andrewspinks Jun 25, 2019
913bd21
update changelog for release 0.6.0
surpher Jun 26, 2019
b182e87
bump cocoapods version to 0.6.0
surpher Jun 26, 2019
feaa5d5
Removes watchOS target and scheme (#64)
surpher Jun 28, 2019
1665942
Remove unused .ruby-version file (#65)
surpher Jun 28, 2019
aa25c8f
Cleanup access controls on classes to hide internal concepts.
andrewspinks Jun 29, 2019
dda985f
Merge pull request #67 from DiUS/cleanup-access-controls
surpher Jun 30, 2019
217b5e2
chore(lint): moved linting into a portable script (#66)
surpher Jul 1, 2019
8a42f89
fix(lint): Parameter alignment
surpher Jul 1, 2019
03d1f5e
readded better handling (and controlling) for pact writing
nonec Jul 3, 2019
31fdfc7
fix: Revert "Refactor pact mock server network calling code and upgra…
andrewspinks Jul 18, 2019
cc66ee5
test: Add test around pact mock service to make refactors easier.
andrewspinks Jul 3, 2019
cacde03
chore: Fix test failures not failing travis build.
andrewspinks Jul 27, 2019
a611dce
chore: Only run coverage report when tests pass
andrewspinks Jul 27, 2019
57ccbd6
fix(objc): add escaping modifier to allow for testComplete function t…
marturi Jul 27, 2019
85749c5
chore: Bumping version to 0.6.1
andrewspinks Jul 28, 2019
5b1e1bf
chore: convert release script to be a bash script #46
andrewspinks Jul 28, 2019
8f2c76b
fix: Bump dependencies to support swift 5. Also removes obsolete refe…
surpher Aug 26, 2019
58775a2
chore: Bumping version to 0.6.2
andrewspinks Aug 31, 2019
c91360d
Revert "chore: Bumping version to 0.6.2" due to cocoapods issues.
andrewspinks Aug 31, 2019
f5e34d5
chore: Change minimum swift version to 4.2 due Nimble requirements. A…
andrewspinks Aug 31, 2019
5818586
increased tries for a unique server port generation
nonec Sep 16, 2019
f5b6b65
added a sleep if the server number is in use
nonec Sep 16, 2019
8f9486c
remember (and avoid) already used ports
nonec Sep 16, 2019
1126a00
reformatting
nonec Sep 19, 2019
d50f643
checking the port before opening the server
nonec Sep 19, 2019
3605d53
increased random range and added comment
nonec Sep 19, 2019
29e182d
stronger typing for eachlike
nonec Oct 1, 2019
01effee
style: add convenience init method to MockService which defaults erro…
alannichols Nov 12, 2019
64de4cc
chore: Bumping version to 0.7.1
andrewspinks Nov 15, 2019
d086a7a
feat: add support for macCatalyst (#78)
TomasLinhart Nov 27, 2019
4279255
feat: allow self signed ssl certificates (#74)
georgescumihai Jan 17, 2020
36b8830
Merge remote-tracking branch 'upstream/master'
nonec Jan 20, 2020
3688af8
Merge branch 'feature/nativeWrapperUpdate' into feature/nativeWrapper…
nonec Jan 20, 2020
10ef006
Merge branch 'master' into feature/nativeWrapperCurrent
nonec Jan 22, 2020
72bf346
adjusted for some tests
nonec Jan 22, 2020
8cae3eb
readded swiftjson for tests and removed watch target
nonec Jan 23, 2020
ce32c3e
removed unnecessary casts
nonec Jan 23, 2020
543b859
readded swiftjson for mismatches parsing
nonec Jan 23, 2020
4c77df9
rearranged matcher code for reuse
nonec Jan 23, 2020
d58927e
readding convenience init with matcher
nonec Jan 23, 2020
5c79d0a
convenience
nonec Jan 23, 2020
cfe0fd8
set generate to Any to work with numbers
nonec Jan 23, 2020
37633a3
reordering test folder
nonec Jan 23, 2020
9fa9b8f
renaming ruby mock service
nonec Jan 23, 2020
13b547e
removed unused method
nonec Jan 23, 2020
778879f
removed unrelated method
nonec Jan 23, 2020
b945c9f
further adoptions of testing paths
nonec Jan 23, 2020
b78fa8f
adaptation of MatchingRule for ruby
nonec Jan 23, 2020
a2d53a9
updated minType handling
nonec Jan 23, 2020
a751abb
enabled test for rust
nonec Jan 23, 2020
c28ff13
increase count to verify multiple elements
nonec Jan 23, 2020
3ef6567
removed timeout
nonec Jan 23, 2020
7dad37f
added specific matchers
nonec Jan 23, 2020
90baed8
removed unused timeout
nonec Jan 23, 2020
480ea06
fixed a few swift build errors
nonec Jan 24, 2020
3346a76
removed debug prints
nonec Jan 24, 2020
8815e78
updated podspec
nonec Jan 24, 2020
85a227a
project file cleanup
nonec Jan 24, 2020
d4a8239
added swift include paths
nonec Jan 24, 2020
8a11d64
using swift package for swift build
Jan 30, 2020
c923d83
cleaned up build phases
Jan 30, 2020
5bc390f
updated build versions
Jan 30, 2020
1b6c1c9
removed non existing source
Jan 30, 2020
03a4542
corrected to existing version
Jan 30, 2020
804de2d
added bootstrap command
Jan 30, 2020
073ad58
Revert "added bootstrap command"
Jan 30, 2020
13ad28b
setting to existing simulator
Jan 30, 2020
3f27ff7
added some additional debug for failure to travis
Jan 30, 2020
6945ef6
moved dependencies and bootstrapping to travis
Jan 30, 2020
5b1423a
added carthage cache
Jan 30, 2020
d472375
reduced log output size
Jan 30, 2020
a9a952d
reduced debug further
Jan 30, 2020
75fbe78
moved building to travis config file
Jan 30, 2020
db67bdb
updated phone
Jan 30, 2020
4940d29
only write matching rules once
Jan 31, 2020
c31f085
simple test for pact body builder
Jan 31, 2020
23bcc7c
minor changes on pact file structure
Jan 31, 2020
9901d79
Merge branch 'feature/nativeWrapperCurrent' into feature/nativeWrapperPR
Jan 31, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .ruby-version

This file was deleted.

1 change: 0 additions & 1 deletion .swift-version

This file was deleted.

26 changes: 14 additions & 12 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
language: objective-c
osx_image: xcode9.2
osx_image: xcode11.2
cache:
directories:
- Carthage
env:
global:
- IOS_FRAMEWORK_SCHEME="PactConsumerSwift iOS"
Expand All @@ -8,21 +11,20 @@ env:
- secure: QmmEqePFeG6D1Qu0KrWI0w6LiwiY3V2qUWAHxQrSYFFPG4wJOZuHpwdk9NO45gOzPYxbkzXT9MynWFMs5pZKrIJCmQRkK5fNcDecwvNunsJEzBmvNYLhd0B4IKy2R1pBmKcDHPIYCzgpanPDAV7LhTXlGoUGk59+QL6qK8+hBQs=
- secure: FpfacekFs93LkX9gerQUxQKIDTjBl2abp7ZQ/8L3DiJo4nMF7xEwUGeSDQMR+2hRqRWr/SdU59Lll5k10JBqWxAaLXDTUq3Lh3aamc4nc2PAN7yp+0aq9RQG5+PaLkfx+SLs5B/CjDiRRotZg/H/uMTRRFbkqydVtxiqGv94JOg=
matrix:
- DESTINATION="OS=11.2,name=iPhone 8" SCHEME="$IOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="iOS"
- DESTINATION="OS=10.3.1,name=iPhone 7 Plus" SCHEME="$IOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="iOS"
- DESTINATION="OS=11.2,name=Apple TV" SCHEME="$TVOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="tvOS"
- DESTINATION="arch=x86_64" SCHEME="$MACOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="macOS"
- DESTINATION="OS=11.0,name=Apple TV 4K (at 1080p)" SCHEME="$TVOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="tvOS"
- DESTINATION="arch=x86_64" SCHEME="$MACOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="macOS"
- DESTINATION="OS=12.0,name=iPhone X" SCHEME="$IOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="iOS"
- DESTINATION="OS=11.3,name=iPhone 8" SCHEME="$IOS_FRAMEWORK_SCHEME" CARTHAGE_PLATFORM="iOS"
before_install:
- scripts/import_keychain.sh
- security find-identity -v -p codesigning
- bundle install
- gem install xcpretty
- brew update && brew bundle
- brew outdated carthage || brew upgrade carthage
- brew outdated swiftlint || brew upgrade swiftlint
- carthage checkout
- carthage bootstrap
script:
- set -o pipefail
- scripts/build.sh
- bash <(curl -s https://codecov.io/bash) -J 'PactConsumerSwift'
after_script: scripts/delete_keychain.sh
after_failure:
- tail -n25 $TMPDIR/carthage-*.log
after_success:
- bash <(curl -s https://codecov.io/bash) -J 'PactConsumerSwift'
- scripts/build_children.sh
4 changes: 4 additions & 0 deletions Brewfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
tap 'pact-foundation/pact-ruby-standalone'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid having these changes that were not made by you in the PR I would encourage you to rebase origin:master onto your fork:branchPR, then force push (onto your fork:branchPR!!!) the new history.

That way any of the changes made to origin will not show up in your PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: (for me)
yes, I agree. I'll have to see when I have time for this. Since I think this is what I did the last time.

brew 'carthage'
brew 'swiftlint'
brew 'pact-ruby-standalone'
69 changes: 69 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,74 @@
# 0.7.1 - Bugfix Release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies here regarding rebasing on your PR branch. You haven't made this changes, have you? Therefore they should not be part of your PR. 🤷

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, like above



* 01effee - style: add convenience init method to MockService which defaults error reporting but allows configuration of the verifier. (#77) (alan.nichols@outlook.com, Tue Nov 12 22:22:16 2019 +0000)
* f5e34d5 - chore: Change minimum swift version to 4.2 due Nimble requirements. Also fix cocoapods configuration. (Andrew Spinks, Sat Aug 31 14:55:31 2019 +0900)
* c91360d - Revert "chore: Bumping version to 0.6.2" due to cocoapods issues. (Andrew Spinks, Sat Aug 31 14:50:40 2019 +0900)
* 58775a2 - chore: Bumping version to 0.6.2 (Andrew Spinks, Sat Aug 31 14:11:12 2019 +0900)
* 8f2c76b - fix: Bump dependencies to support swift 5. Also removes obsolete references to Result.framework. (Marko Justinek, Tue Aug 27 00:50:46 2019 +0200)
* 5b1e1bf - chore: convert release script to be a bash script #46 (Andrew Spinks, Sun Jul 28 10:32:30 2019 +0900)
# 0.7.0 - Bugfix Release


* 16bbf44 - chore: Change minimum swift version to 4.2 due Nimble requirements. Also fix cocoapods configuration. (Andrew Spinks, Sat Aug 31 14:55:31 2019 +0900)
* c91360d - Revert "chore: Bumping version to 0.6.2" due to cocoapods issues. (Andrew Spinks, Sat Aug 31 14:50:40 2019 +0900)
* 58775a2 - chore: Bumping version to 0.6.2 (Andrew Spinks, Sat Aug 31 14:11:12 2019 +0900)
* 8f2c76b - fix: Bump dependencies to support swift 5. Also removes obsolete references to Result.framework. (Marko Justinek, Tue Aug 27 00:50:46 2019 +0200)
* 5b1e1bf - chore: convert release script to be a bash script #46 (Andrew Spinks, Sun Jul 28 10:32:30 2019 +0900)
-en # 0.6.1 - Bugfix Release


* 57ccbd6 - fix(objc): add escaping modifier to allow for testComplete function to be called… (#71) (Matt Arturi, Sat Jul 27 09:43:09 2019 -0400)
* a611dce - chore: Only run coverage report when tests pass (Andrew Spinks, Sat Jul 27 20:48:05 2019 +0900)
* cacde03 - chore: Fix test failures not failing travis build. (Andrew Spinks, Sat Jul 27 20:47:52 2019 +0900)
* cc66ee5 - test: Add test around pact mock service to make refactors easier. (Andrew Spinks, Wed Jul 3 19:29:27 2019 +0900)
* 31fdfc7 - fix: Revert "Refactor pact mock server network calling code and upgrade to swift 5 (#53)" which introduced a bug where messages from the mock server were no longer being returned. (Andrew Spinks, Thu Jul 18 17:35:45 2019 +0900)
* 8a42f89 - fix(lint): Parameter alignment (Marko Justinek, Tue Jul 2 06:29:45 2019 +1000)
* 217b5e2 - chore(lint): moved linting into a portable script (#66) (Marko Justinek, Mon Jul 1 21:00:51 2019 +1000)
* aa25c8f - Cleanup access controls on classes to hide internal concepts. (Andrew Spinks, Sat Jun 29 16:50:33 2019 +0900)
* 1665942 - Remove unused .ruby-version file (#65) (Marko Justinek, Fri Jun 28 17:32:07 2019 +1000)
* feaa5d5 - Removes watchOS target and scheme (#64) (Marko Justinek, Fri Jun 28 17:30:39 2019 +1000)


# 0.6.0 - Maintenance Release

* 9605227 - Cleanup build settings so ci build can be more easily reproduced locally. (#59) (andrewspinks, Tue Jun 25 17:32:54 2019 +0900)
* cdecfbc - Fixes bitcode related issue when used from CocoaPods. (Kyle Hammond, Mon Jun 24 10:36:16 2019 -0500)
* 848f4c5 - Remove quick dependency from requirements. It is only used for internal tests. (#58) (andrewspinks, Sun Jun 23 11:19:26 2019 +0900)
* 8688fdc - Refactor pact mock server network calling code and upgrade to swift 5 (#53) (Marko Justinek, Wed Jun 19 17:32:45 2019 +1000)
* 23296ce - Completely removed Alamofire in favor of simple networking calls. (#51) (Kyle Hammond, Wed Jun 12 18:53:11 2019 -0500)
* 3ed97f1 - Update dependencies (Mihai Georgescu, Mon Mar 25 23:12:14 2019 +0000)
* 28e1588 - Fix cocoa pods release version number and release script. (Andrew Spinks, Thu Jan 24 20:17:51 2019 +0900)

# 0.5.3 - Bugfix Release

* a1cd000 - Update cocoapods dependencies. (Andrew Spinks, Thu Jan 24 19:34:14 2019 +0900)
* 5ebc062 - Update pact-mock-service versions (Andrew Spinks, Thu Jan 24 17:29:40 2019 +0900)
* 2e77868 - Update Cartfile.resolved for use with bootstrap on CI (Marko Justinek, Thu Jan 24 09:06:45 2019 +1100)
* f8899f8 - Update Quick dependency to use “master” (Marko Justinek, Thu Jan 24 08:38:31 2019 +1100)
* 596b6b8 - Update travis CI env matrix (Marko Justinek, Thu Jan 24 08:26:12 2019 +1100)
* 8c4d3cf - Bumps up versions of all dependencies (Marko Justinek, Wed Jan 23 23:58:20 2019 +1100)
* 4198e38 - Bump up Alamofire version (Marko Justinek, Wed Jan 23 23:47:04 2019 +1100)
* 5897e28 - Updates travis pipeline to run tests on iOS 12.1 and 11.3 (Marko Justinek, Wed Jan 23 23:30:14 2019 +1100)
* 0e7212b - Project updates for Swift 4.2 (Marko Justinek, Wed Jan 23 23:21:23 2019 +1100)
* 6ca5c37 - Update BrightFutures dependency version (Marko Justinek, Wed Jan 23 23:12:39 2019 +1100)
* d639fe7 - Update readme (Marko Justinek, Wed Jan 23 23:12:23 2019 +1100)
* e1c4596 - Removed reference to non-standalone pact mock service (Marko Justinek, Fri May 18 11:00:12 2018 +1000)
* 2a667c2 - Updates README to encourage usage of pact-ruby-standalone (Marko Justinek, Thu May 17 08:27:07 2018 +1000)
* 5ec6eb3 - bump cocoapods version to 0.5.2 (Andrew Spinks, Tue May 8 17:22:01 2018 +0900)

# 0.5.2 - Bugfix Release

* 52cf980 - Update release script to work better with cocoa pods (Andrew Spinks, Tue May 8 17:09:25 2018 +0900)
* 2bc59b5 - Update gems (Andrew Spinks, Tue May 8 16:26:54 2018 +0900)
* 6749fdc - Merge pull request #38 from stitchfix/master (andrewspinks, Tue May 1 11:46:08 2018 +0900)
* 26cab90 - Update BrightFutures (Robbin Voortman, Wed Apr 25 08:51:25 2018 +0200)
* b538409 - wait on verify to complete before allowing tests to continue to prevent race condition (Eric Vennaro, Tue Apr 24 15:31:03 2018 -0700)
* 3e1edc3 - move to brew update (Stephen, Thu Jan 4 16:42:57 2018 -0800)
* db7abe5 - move to brew bundle (Stephen, Thu Jan 4 15:37:59 2018 -0800)
* 8bc8fc0 - Create Brewfile (Stephen, Thu Jan 4 15:37:26 2018 -0800)
* 9c5678b - Update cocopods version number (Andrew Spinks, Thu Oct 26 19:19:37 2017 +0900)

# 0.5.1 - Bugfix Release

* 1b6ba70 - Fixed issue preventing the pact writing (Angel G. Olloqui, Wed Oct 25 12:30:38 2017 +0200)
Expand Down
15 changes: 10 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# Contributing to Pact Consumer Swift project

### Prepare your development environment
The Pact Consumer Swift library is using Carthage and Swift Package Manager to manage library dependencies. You should install [Carthage](https://github.com/Carthage/Carthage) using [Homebrew](https://brew.sh), then download and build the dependencies using `carthage bootstrap` (Carthage), or `swift package resolve` (SwiftPM).
The Pact Consumer Swift library is using Carthage and Swift Package Manager to manage library dependencies. You should install [Carthage](https://github.com/Carthage/Carthage) using [Homebrew](https://brew.sh), then download and build the dependencies using `carthage bootstrap` (Carthage).

Required build dependencies can be installed by running:
```
./scripts/install_deps.sh
```

### Running tests with default destination
```
Expand All @@ -10,12 +15,12 @@ The Pact Consumer Swift library is using Carthage and Swift Package Manager to m
defaults to iOS 11 on iPhone 8

### Running specific platform tests
iOS 10.3 on iPhone 7:
iOS 10.3 on iPhone 7:
```
xcodebuild -project PactConsumerSwift.xcodeproj -scheme "PactConsumerSwift iOS" -destination "OS=10.3,name=iPhone 7" -configuration Debug ONLY_ACTIVE_ARCH=NO ENABLE_TESTABILITY=YES test | xcpretty;
```

for macOS:
for macOS:
```
xcodebuild -project PactConsumerSwift.xcodeproj -scheme "PactConsumerSwift macOS" -destination "arch=x86_64" -configuration Debug ONLY_ACTIVE_ARCH=NO ENABLE_TESTABILITY=YES test | xcpretty;
```
Expand Down Expand Up @@ -50,7 +55,7 @@ For more information, see the [.travis.yml](/.travis.yml) configuration.
Builds on [Travis CI](https://travis-ci.org/DiUS/pact-consumer-swift/) with pipeline configuration in [.travis.yml](/.travis.yml).

### Release
[release.groovy](/release.groovy) script helps with updating the Changelog, tagging the commit with a release version, and publish to Cocoapods.
[release.sh](/scripts/release.sh) script helps with updating the Changelog, tagging the commit with a release version, and publish to Cocoapods.
```
groovy release.groovy
./scripts/release.sh 0.7.0 "Bugfix Release"
```
7 changes: 3 additions & 4 deletions Cartfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
github "Alamofire/Alamofire" ~> 4.6
github "Thomvis/BrightFutures" ~> 6.0
github "Quick/Nimble" ~> 7.0
github "SwiftyJSON/SwiftyJSON" ~> 4.0
github "Thomvis/BrightFutures" ~> 8.0
github "Quick/Nimble" ~> 8.0
github "SwiftyJSON/SwiftyJSON" ~> 5.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After having Codable available to us since Swift 4, I'd encourage you to avoid bringing in more dependencies for things that Swift can do for by just using what Foundation provides.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also something I agree on. Original the branch was done by @andrewspinks . When I first started working on this my goal was to get it to a point that it can be merged back.
Since Codable came up I thought about this, but the top priority was to get everything else working right first.

3 changes: 2 additions & 1 deletion Cartfile.private
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
github "Quick/Quick" ~> 1.1
github "Quick/Quick" ~> 2.0
github "AliSoftware/OHHTTPStubs"
Copy link
Contributor

@surpher surpher Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not you @nonec but if you run carthage update now it will pull version 9.0.0 and it will break current implementation of tests as this dependency dropped OH prefix from all its class names. All it will bring is a headache. :|

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a headache, yes :|

11 changes: 5 additions & 6 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
github "Alamofire/Alamofire" "4.6.0"
github "Quick/Nimble" "v7.0.3"
github "Quick/Quick" "v1.2.0"
github "SwiftyJSON/SwiftyJSON" "4.0.0"
github "Thomvis/BrightFutures" "6.0.0"
github "antitypical/Result" "3.2.4"
github "AliSoftware/OHHTTPStubs" "8.0.0"
github "Quick/Nimble" "v8.0.5"
github "Quick/Quick" "v2.2.0"
github "SwiftyJSON/SwiftyJSON" "5.0.0"
github "Thomvis/BrightFutures" "8.0.1"
10 changes: 8 additions & 2 deletions .swiftlint.yml → Configuration/swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ force_try:
type_body_length:
- 300 # warning
- 400 # error
line_length:
warning: 128
error: 156
file_length:
warning: 500
error: 1200
Expand All @@ -30,8 +33,11 @@ identifier_name:
- id
- URL
- url
- GET
- PUT
- min
- max
- key
- GET
- PUT
- get
- put
reporter: "xcode"
4 changes: 0 additions & 4 deletions Gemfile

This file was deleted.

Loading