-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/native wrapper pr #50
Changes from all commits
8bc8fc0
db7abe5
3e1edc3
38d5055
b538409
26cab90
c7d1ed5
6749fdc
2bc59b5
52cf980
2b4f5e0
5ec6eb3
2a667c2
e1c4596
58387dd
d639fe7
6ca5c37
0e7212b
5897e28
4198e38
8c4d3cf
596b6b8
f8899f8
2e77868
f2f4ec7
5ebc062
a1cd000
c4d696b
3db2587
28e1588
3ed97f1
753a36a
581ee68
cd51034
8ad91b9
aac72c7
9bb0ab7
66721ef
c96241e
de83bc5
3d2671e
687db85
02ad112
9debdf3
04e70a4
f99eda6
5f1616e
b5b6e6d
5b6bda8
aead22b
45878a9
75859ad
d1f16af
a851de6
06e9f4a
220feb9
d157963
9a5df7c
67ef810
ca86d56
1af6e69
6ab1eab
f0fb433
017ee95
e393f9b
2273ce8
80c3a48
84952f5
be951a4
8a53233
f89027c
86b3b59
46169a1
20591fe
b7305a4
23a0f84
805d100
fb647e3
417ba24
98cc356
3937764
12600ae
8ce1b01
4d28901
4fd4205
d39c744
cdfc34d
6917fff
aeb27e0
af7db06
188862a
9be3bb1
cf390bf
c78c673
da8ddb8
289bc8a
9843a58
2984711
1a3f7b6
23296ce
8688fdc
848f4c5
cdecfbc
f00421a
9605227
913bd21
b182e87
feaa5d5
1665942
aa25c8f
dda985f
217b5e2
8a42f89
03d1f5e
31fdfc7
cc66ee5
cacde03
a611dce
57ccbd6
85749c5
5b1e1bf
8f2c76b
58775a2
c91360d
f5e34d5
5818586
f5b6b65
8f9486c
1126a00
d50f643
3605d53
29e182d
01effee
64de4cc
d086a7a
4279255
36b8830
3688af8
10ef006
72bf346
8cae3eb
ce32c3e
543b859
4c77df9
d58927e
5c79d0a
cfe0fd8
37633a3
9fa9b8f
13b547e
778879f
b945c9f
b78fa8f
a2d53a9
a751abb
c28ff13
3ef6567
7dad37f
90baed8
480ea06
3346a76
8815e78
85a227a
d4a8239
8a11d64
c923d83
5bc390f
1b6c1c9
03a4542
804de2d
073ad58
13ad28b
3f27ff7
6945ef6
5b1423a
d472375
a9a952d
75fbe78
db67bdb
4940d29
c31f085
23bcc7c
9901d79
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
tap 'pact-foundation/pact-ruby-standalone' | ||
brew 'carthage' | ||
brew 'swiftlint' | ||
brew 'pact-ruby-standalone' |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,74 @@ | ||
# 0.7.1 - Bugfix Release | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same applies here regarding rebasing on your PR branch. You haven't made this changes, have you? Therefore they should not be part of your PR. 🤷 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, like above |
||
|
||
|
||
* 01effee - style: add convenience init method to MockService which defaults error reporting but allows configuration of the verifier. (#77) (alan.nichols@outlook.com, Tue Nov 12 22:22:16 2019 +0000) | ||
* f5e34d5 - chore: Change minimum swift version to 4.2 due Nimble requirements. Also fix cocoapods configuration. (Andrew Spinks, Sat Aug 31 14:55:31 2019 +0900) | ||
* c91360d - Revert "chore: Bumping version to 0.6.2" due to cocoapods issues. (Andrew Spinks, Sat Aug 31 14:50:40 2019 +0900) | ||
* 58775a2 - chore: Bumping version to 0.6.2 (Andrew Spinks, Sat Aug 31 14:11:12 2019 +0900) | ||
* 8f2c76b - fix: Bump dependencies to support swift 5. Also removes obsolete references to Result.framework. (Marko Justinek, Tue Aug 27 00:50:46 2019 +0200) | ||
* 5b1e1bf - chore: convert release script to be a bash script #46 (Andrew Spinks, Sun Jul 28 10:32:30 2019 +0900) | ||
# 0.7.0 - Bugfix Release | ||
|
||
|
||
* 16bbf44 - chore: Change minimum swift version to 4.2 due Nimble requirements. Also fix cocoapods configuration. (Andrew Spinks, Sat Aug 31 14:55:31 2019 +0900) | ||
* c91360d - Revert "chore: Bumping version to 0.6.2" due to cocoapods issues. (Andrew Spinks, Sat Aug 31 14:50:40 2019 +0900) | ||
* 58775a2 - chore: Bumping version to 0.6.2 (Andrew Spinks, Sat Aug 31 14:11:12 2019 +0900) | ||
* 8f2c76b - fix: Bump dependencies to support swift 5. Also removes obsolete references to Result.framework. (Marko Justinek, Tue Aug 27 00:50:46 2019 +0200) | ||
* 5b1e1bf - chore: convert release script to be a bash script #46 (Andrew Spinks, Sun Jul 28 10:32:30 2019 +0900) | ||
-en # 0.6.1 - Bugfix Release | ||
|
||
|
||
* 57ccbd6 - fix(objc): add escaping modifier to allow for testComplete function to be called… (#71) (Matt Arturi, Sat Jul 27 09:43:09 2019 -0400) | ||
* a611dce - chore: Only run coverage report when tests pass (Andrew Spinks, Sat Jul 27 20:48:05 2019 +0900) | ||
* cacde03 - chore: Fix test failures not failing travis build. (Andrew Spinks, Sat Jul 27 20:47:52 2019 +0900) | ||
* cc66ee5 - test: Add test around pact mock service to make refactors easier. (Andrew Spinks, Wed Jul 3 19:29:27 2019 +0900) | ||
* 31fdfc7 - fix: Revert "Refactor pact mock server network calling code and upgrade to swift 5 (#53)" which introduced a bug where messages from the mock server were no longer being returned. (Andrew Spinks, Thu Jul 18 17:35:45 2019 +0900) | ||
* 8a42f89 - fix(lint): Parameter alignment (Marko Justinek, Tue Jul 2 06:29:45 2019 +1000) | ||
* 217b5e2 - chore(lint): moved linting into a portable script (#66) (Marko Justinek, Mon Jul 1 21:00:51 2019 +1000) | ||
* aa25c8f - Cleanup access controls on classes to hide internal concepts. (Andrew Spinks, Sat Jun 29 16:50:33 2019 +0900) | ||
* 1665942 - Remove unused .ruby-version file (#65) (Marko Justinek, Fri Jun 28 17:32:07 2019 +1000) | ||
* feaa5d5 - Removes watchOS target and scheme (#64) (Marko Justinek, Fri Jun 28 17:30:39 2019 +1000) | ||
|
||
|
||
# 0.6.0 - Maintenance Release | ||
|
||
* 9605227 - Cleanup build settings so ci build can be more easily reproduced locally. (#59) (andrewspinks, Tue Jun 25 17:32:54 2019 +0900) | ||
* cdecfbc - Fixes bitcode related issue when used from CocoaPods. (Kyle Hammond, Mon Jun 24 10:36:16 2019 -0500) | ||
* 848f4c5 - Remove quick dependency from requirements. It is only used for internal tests. (#58) (andrewspinks, Sun Jun 23 11:19:26 2019 +0900) | ||
* 8688fdc - Refactor pact mock server network calling code and upgrade to swift 5 (#53) (Marko Justinek, Wed Jun 19 17:32:45 2019 +1000) | ||
* 23296ce - Completely removed Alamofire in favor of simple networking calls. (#51) (Kyle Hammond, Wed Jun 12 18:53:11 2019 -0500) | ||
* 3ed97f1 - Update dependencies (Mihai Georgescu, Mon Mar 25 23:12:14 2019 +0000) | ||
* 28e1588 - Fix cocoa pods release version number and release script. (Andrew Spinks, Thu Jan 24 20:17:51 2019 +0900) | ||
|
||
# 0.5.3 - Bugfix Release | ||
|
||
* a1cd000 - Update cocoapods dependencies. (Andrew Spinks, Thu Jan 24 19:34:14 2019 +0900) | ||
* 5ebc062 - Update pact-mock-service versions (Andrew Spinks, Thu Jan 24 17:29:40 2019 +0900) | ||
* 2e77868 - Update Cartfile.resolved for use with bootstrap on CI (Marko Justinek, Thu Jan 24 09:06:45 2019 +1100) | ||
* f8899f8 - Update Quick dependency to use “master” (Marko Justinek, Thu Jan 24 08:38:31 2019 +1100) | ||
* 596b6b8 - Update travis CI env matrix (Marko Justinek, Thu Jan 24 08:26:12 2019 +1100) | ||
* 8c4d3cf - Bumps up versions of all dependencies (Marko Justinek, Wed Jan 23 23:58:20 2019 +1100) | ||
* 4198e38 - Bump up Alamofire version (Marko Justinek, Wed Jan 23 23:47:04 2019 +1100) | ||
* 5897e28 - Updates travis pipeline to run tests on iOS 12.1 and 11.3 (Marko Justinek, Wed Jan 23 23:30:14 2019 +1100) | ||
* 0e7212b - Project updates for Swift 4.2 (Marko Justinek, Wed Jan 23 23:21:23 2019 +1100) | ||
* 6ca5c37 - Update BrightFutures dependency version (Marko Justinek, Wed Jan 23 23:12:39 2019 +1100) | ||
* d639fe7 - Update readme (Marko Justinek, Wed Jan 23 23:12:23 2019 +1100) | ||
* e1c4596 - Removed reference to non-standalone pact mock service (Marko Justinek, Fri May 18 11:00:12 2018 +1000) | ||
* 2a667c2 - Updates README to encourage usage of pact-ruby-standalone (Marko Justinek, Thu May 17 08:27:07 2018 +1000) | ||
* 5ec6eb3 - bump cocoapods version to 0.5.2 (Andrew Spinks, Tue May 8 17:22:01 2018 +0900) | ||
|
||
# 0.5.2 - Bugfix Release | ||
|
||
* 52cf980 - Update release script to work better with cocoa pods (Andrew Spinks, Tue May 8 17:09:25 2018 +0900) | ||
* 2bc59b5 - Update gems (Andrew Spinks, Tue May 8 16:26:54 2018 +0900) | ||
* 6749fdc - Merge pull request #38 from stitchfix/master (andrewspinks, Tue May 1 11:46:08 2018 +0900) | ||
* 26cab90 - Update BrightFutures (Robbin Voortman, Wed Apr 25 08:51:25 2018 +0200) | ||
* b538409 - wait on verify to complete before allowing tests to continue to prevent race condition (Eric Vennaro, Tue Apr 24 15:31:03 2018 -0700) | ||
* 3e1edc3 - move to brew update (Stephen, Thu Jan 4 16:42:57 2018 -0800) | ||
* db7abe5 - move to brew bundle (Stephen, Thu Jan 4 15:37:59 2018 -0800) | ||
* 8bc8fc0 - Create Brewfile (Stephen, Thu Jan 4 15:37:26 2018 -0800) | ||
* 9c5678b - Update cocopods version number (Andrew Spinks, Thu Oct 26 19:19:37 2017 +0900) | ||
|
||
# 0.5.1 - Bugfix Release | ||
|
||
* 1b6ba70 - Fixed issue preventing the pact writing (Angel G. Olloqui, Wed Oct 25 12:30:38 2017 +0200) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
github "Alamofire/Alamofire" ~> 4.6 | ||
github "Thomvis/BrightFutures" ~> 6.0 | ||
github "Quick/Nimble" ~> 7.0 | ||
github "SwiftyJSON/SwiftyJSON" ~> 4.0 | ||
github "Thomvis/BrightFutures" ~> 8.0 | ||
github "Quick/Nimble" ~> 8.0 | ||
github "SwiftyJSON/SwiftyJSON" ~> 5.0.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After having There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also something I agree on. Original the branch was done by @andrewspinks . When I first started working on this my goal was to get it to a point that it can be merged back. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
github "Quick/Quick" ~> 1.1 | ||
github "Quick/Quick" ~> 2.0 | ||
github "AliSoftware/OHHTTPStubs" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know this is not you @nonec but if you run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is a headache, yes :| |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
github "Alamofire/Alamofire" "4.6.0" | ||
github "Quick/Nimble" "v7.0.3" | ||
github "Quick/Quick" "v1.2.0" | ||
github "SwiftyJSON/SwiftyJSON" "4.0.0" | ||
github "Thomvis/BrightFutures" "6.0.0" | ||
github "antitypical/Result" "3.2.4" | ||
github "AliSoftware/OHHTTPStubs" "8.0.0" | ||
github "Quick/Nimble" "v8.0.5" | ||
github "Quick/Quick" "v2.2.0" | ||
github "SwiftyJSON/SwiftyJSON" "5.0.0" | ||
github "Thomvis/BrightFutures" "8.0.1" |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid having these changes that were not made by you in the PR I would encourage you to rebase
origin:master
onto yourfork:branchPR
, then force push (onto yourfork:branchPR
!!!) the new history.That way any of the changes made to origin will not show up in your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: (for me)
yes, I agree. I'll have to see when I have time for this. Since I think this is what I did the last time.