Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to be compatible with latest odin-data #24

Closed
GDYendell opened this issue Nov 28, 2024 · 2 comments
Closed

Update to be compatible with latest odin-data #24

GDYendell opened this issue Nov 28, 2024 · 2 comments

Comments

@GDYendell
Copy link
Contributor

GDYendell commented Nov 28, 2024

Currently these changes are in pending PRs, so ADOdin would need to be tested against the command-dev branch of odin-data. The easiest way to test this is to run the fastcs-odin full development environment and check out this branch instead of fastcs-dev to run the local deployment, and run ADOdin instead of (or as well as) the fastcs-odin IOC.

These are the changes, all of which should be testable with the local deployment:

Parameter URIs changed (odin-detector/odin-data#369):
  • hdf/file/name -> hdf/file/prefix
  • decoder/name -> decoder/class (possibly unused?)

Acceptance Criteria: The new parameter can be set and read back

File writer write config changed to start_writing and stop_writing commands (odin-detector/odin-data#372)
  • config/hdf/file/write = true/false ->
    • command/hdf/start_writing
    • command/hdf/stop_writing

These commands are implemented in the driver code here

Acceptance Criteria: File writing can be started and stopped

Top-level parameters have been removed from the adapter and clients must now poke each underlying value (odin-detector/odin-data#373)

There are different ways that could be solved. The most obvious is to add some database logic in fan out the puts to the indexed records. The first step here is to check how many of these there are and report back so we can discuss the best approach.

Acceptance Criteria: All indexed configs can be set with one top-level PV

@GDYendell GDYendell converted this from a draft issue Nov 28, 2024
@jsouter
Copy link
Contributor

jsouter commented Dec 12, 2024

Looks like the EigerFanAdapter PVs are broken when running the eiger example ioc in ADOdin v1 against odin-data/parameter-tree (that adapter basically just inherits from OdinDataAdapter and adds no additional functionality). It seems like the parameters are getting added to the ParameterTree correctly, will have to investigate what's going wrong there.

@GDYendell
Copy link
Contributor Author

This is going to be too difficult. The current interface between ADOdin and the old adapters is too messy to recreate with ParameterTree in a sane way.

@github-project-automation github-project-automation bot moved this from Current Sprint to Done in FastCS Development Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants