Initial command implementation for odin-data. #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e functionality. Fixed runtime error in Dummy plugin and throw an exception if the supported command is not requested when execution is called. Added tests that use the Dummy plugin to test execute and requestCommands methods. Update cpp/frameProcessor/test/DummyUDPProcessPluginTest.cpp Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk> Added clarification comments. Simplified boost test calls. Updated to use string commands with no parameters. Removed unused test code. Removed unused execution parameter constant.
Implemented command and requestCommands methods in the FrameProcessor.
Update FrameProcessorAdapter to use execute_command for write commands
Update ipc_tornado_client to correctly manage rejected messages. Update frame_processor_adapter to utilise correctly managed messages and implement a ParameterTree. Created new controller classes that update a parameter tree with config/status Created adapters to interact with the controller classes. Swap rank and status/config in API structure e.g. fp/status/0/... -> fp/0/status/... Expand endpoints list param into scalar ip and port Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
Update vscode CMake config to install into /odin Add publish of build container. This is used as a base for detector developer containers on where they have the full dev environment but also have odin-data installed in /odin to build against. Add python3.11 install Add hdf5filters install for compression libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These IpcClient changes are possibly already pushed in another branch and will need checking.