Add devcontainer #341
Merged
Add devcontainer #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @gilesknap! With the one commit I have added the devcontainer builds and it works really nicely. I have updated the README to simplify things here. The only issue currently is it also needs the controller-nesting branch of FastCS, which should be merged soon. The build is failing because in the fastcs-dev branch I have temporarily removed the direct URL odin-control dependency. |
|
Cool - glad you got that working! The changes look all good to me. |
GDYendell
force-pushed
the
fastcs-dev
branch
2 times, most recently
from
747fdec to
b2b241d
Compare
GDYendell
force-pushed
the
fastcs-dev
branch
2 times, most recently
from
55c0afa to
829ff62
Compare
jsouter
pushed a commit
to jsouter/odin-data
that referenced
this pull request
Jun 20, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
GDYendell
added a commit
that referenced
this pull request
Jun 24, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
GDYendell
added a commit
that referenced
this pull request
Aug 29, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
jsouter
pushed a commit
to jsouter/odin-data
that referenced
this pull request
Oct 24, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
jsouter
pushed a commit
to jsouter/odin-data
that referenced
this pull request
Oct 29, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
jsouter
pushed a commit
to jsouter/odin-data
that referenced
this pull request
Nov 20, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
GDYendell
added a commit
that referenced
this pull request
Nov 27, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
GDYendell
added a commit
that referenced
this pull request
Dec 13, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
GDYendell
added a commit
that referenced
this pull request
Dec 13, 2024
* add docker build and devcontainer * add vscode config --------- Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following: