Update to work with a deployment of multiple frame processors #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
===========================================
+ Coverage 52.80% 63.53% +10.73%
===========================================
Files 5 5
Lines 214 266 +52
===========================================
+ Hits 113 169 +56
+ Misses 101 97 -4 ☔ View full report in Codecov by Sentry. |
gilesknap
reviewed
May 22, 2024
There was a problem hiding this comment.
To make this easier I have made a PR into odin-data fastcs-dev branch here: odin-detector/odin-data#341.
Once this is merged then the instructions for setting up a dev environment are simplified to:
clone odin-data fastcs-dev branch next door to odin-fastcs
open odin-data in vscode and re-open in container
-------------------------------------------------------
cd ../odin-fastcs
pip install -r dev/requirements.txt
pip install -e '.[dev]'
dev/configure.sh /odin /odin/venv
Hit Enter in right pane of zellij
Debug -> Odin IOC(odin-fastcs)
Both fast-cs and odin data can then be modified and tested in this container.
BTW I these instructions could be easily scripted. Caveat that this would be for inside container only.
|
Hi Gary, do you need any more from me on this PR? |
Add docstrings
This is used for adapters called "fp" and removes "status" and "config" from the parameter path.
GDYendell
changed the title
Add support for multiple deployments in dev environment Remove workspaceFolder from devcontainer config Update README to use odin-data devcontainer Create odin extra for local development Print prompt to delete existing local deployment
GDYendell
force-pushed
the
dev
branch
2 times, most recently
from
0ad7b7c to
8d7694d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes various code changes to work with a deployment of multiple frame processors and makes further improvements to the development environment to run against local odin-data deployments.