Skip to content

Allow creating CA IOCs via yaml config #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Conversation

GDYendell
Copy link
Contributor

This enables creating either ca or pva IOCs via yaml config by giving them uniquely named fields.

Fixes #145

@GDYendell GDYendell requested review from LuisFSegalla and jsouter May 23, 2025 14:33
@GDYendell GDYendell self-assigned this May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (6ee1578) to head (5ea717f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files          40       40           
  Lines        1962     1962           
=======================================
  Hits         1800     1800           
  Misses        162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Make CA and PVA options models unique so that they can be distinguised
in the yaml config.
Fix demo PV prefix.
@GDYendell GDYendell force-pushed the epics-options-models branch from 155aa51 to 5ea717f Compare May 27, 2025 09:19
Copy link
Contributor

@LuisFSegalla LuisFSegalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!
Managed to run all the tests and couldn't find anything wrong or that needed change

@GDYendell GDYendell merged commit fdcab7a into main May 27, 2025
18 checks passed
@GDYendell GDYendell deleted the epics-options-models branch May 27, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not possible to create a CA IOC from yaml now that PVA has been added because the schema is the same
2 participants